Skip to content

Commit 1a5ba79

Browse files
author
haotian
committed
AJ-704:fix broken case
1 parent fa9ea54 commit 1a5ba79

File tree

1 file changed

+22
-18
lines changed

1 file changed

+22
-18
lines changed

test/com/xxdb/SimpleDBConnectionPoolTest.java

Lines changed: 22 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -72,41 +72,45 @@ public void test_SimpleDBConnectionPool_config_newversion(){
7272
assertEquals(5,config.getMaximumPoolSize());
7373
}
7474
@Test
75-
public void test_SimpleDBConnectionPool_config_MinimumandPoolSize_error() {
76-
config.setMinimumPoolSize(-1);
75+
public void test_SimpleDBConnectionPool_config_MinimumandPoolSize_and_MaximumPoolSize_null() {
7776
pool = new SimpleDBConnectionPool(config);
7877
assertEquals(5, config.getMinimumPoolSize());
79-
80-
config.setMinimumPoolSize(0);
78+
assertEquals(5, config.getMaximumPoolSize());
79+
}
80+
@Test
81+
public void test_SimpleDBConnectionPool_config_maxpoolsize_minpoolsize_realtion() {
82+
config.setMaximumPoolSize(6);
83+
config.setMinimumPoolSize(-1);
8184
pool = new SimpleDBConnectionPool(config);
8285
assertEquals(5, config.getMinimumPoolSize());
83-
84-
config.setMinimumPoolSize(6);
85-
pool = new SimpleDBConnectionPool(config);
86-
assertEquals(6, config.getMinimumPoolSize());
8786
assertEquals(6, config.getMaximumPoolSize());
8887

89-
}
90-
@Test
91-
public void test_SimpleDBConnectionPool_config_MinimumandPoolSize_null() {
88+
config.setMaximumPoolSize(-4);
89+
config.setMinimumPoolSize(-6);
9290
pool = new SimpleDBConnectionPool(config);
9391
assertEquals(5, config.getMinimumPoolSize());
92+
assertEquals(5, config.getMaximumPoolSize());
9493
}
9594
@Test
96-
public void test_SimpleDBConnectionPool_config_MaximumPoolSize_error() {
97-
config.setMaximumPoolSize(0);
95+
public void test_SimpleDBConnectionPool_config_maxpoolsize_minpoolsize_realtion_error() {
96+
config.setMaximumPoolSize(4);
97+
config.setMinimumPoolSize(6);
9898
pool = new SimpleDBConnectionPool(config);
99-
assertEquals(5, config.getMaximumPoolSize());
99+
assertEquals(6, config.getMaximumPoolSize());
100+
assertEquals(6, config.getMaximumPoolSize());
100101

101102
config.setMaximumPoolSize(-5);
103+
config.setMinimumPoolSize(6);
102104
pool = new SimpleDBConnectionPool(config);
103-
assertEquals(5, config.getMaximumPoolSize());
105+
assertEquals(6, config.getMaximumPoolSize());
106+
assertEquals(6, config.getMaximumPoolSize());
104107

105-
}
106-
@Test
107-
public void test_SimpleDBConnectionPool_config_MaximumPoolSize_null() {
108+
config.setMaximumPoolSize(-4);
109+
config.setMinimumPoolSize(-2);
108110
pool = new SimpleDBConnectionPool(config);
109111
assertEquals(5, config.getMaximumPoolSize());
112+
assertEquals(5, config.getMaximumPoolSize());
113+
110114
}
111115
@Test
112116
public void test_SimpleDBConnectionPool_config_InvalididleTimeout_error() {

0 commit comments

Comments
 (0)