Skip to content
This repository was archived by the owner on Oct 28, 2020. It is now read-only.
This repository was archived by the owner on Oct 28, 2020. It is now read-only.

[issue]: terminal pipeline #117

@seognil

Description

@seognil

I run es-check es5 project/**/*.js | grep 'erroring file' multi times in my project

It said:

ES-Check: there were 79 ES version matching errors.
          · erroring file: xxxA.js
          · erroring file: xxxB.js
          · erroring file: xxxC.js

There were always 79 error files in my project, that's ok,
but grep erroring file count seems random, sometimes 63, sometimes 47,
I just can't tell what all those files are.


Also meet this problem while using it in Node (maybe make an incode requirable version as well?)

exec('es-check es5 myFolder', (err, stdout, stderr) => {
    console.log(err)
});

I check your code

I think this issue may be caused by process.exit...
forEach is synchronous but log is not?
So it return before log all the items

and don't use logger.error for everything...
e.g.

logger.error(`ES-Check: there were no ES version matching errors!  🎉`)
// => better
logger.log(`ES-Check: there were no ES version matching errors!  🎉`)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions