Extension manager: when no url or upload given, do nothing

splitbrain · splitbrain · commit 9b006b5f7a63 · 2025-07-22T21:30:40.000+02:00
diff --git a/lib/plugins/extension/Installer.php b/lib/plugins/extension/Installer.php
@@ -39,7 +39,6 @@ class Installer
     public const STATUS_INSTALLED = 'installed';
     public const STATUS_REMOVED = 'removed';
 
-
     /**
      * Initialize a new extension installer
      *
diff --git a/lib/plugins/extension/admin.php b/lib/plugins/extension/admin.php
@@ -62,7 +62,7 @@ public function handle()
             }
             if ($INPUT->post->str('installurl')) {
                 $installer->installFromURL($INPUT->post->str('installurl'));
-            } elseif (isset($_FILES['installfile'])) {
+            } elseif (isset($_FILES['installfile']) && $_FILES['installfile']['error'] !== UPLOAD_ERR_NO_FILE) {
                 $installer->installFromUpload('installfile');
             }
         } catch (Exception $e) {

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ class Installer`
`39`	`39`	`public const STATUS_INSTALLED = 'installed';`
`40`	`40`	`public const STATUS_REMOVED = 'removed';`
`41`	`41`
`42`		`-`
`43`	`42`	`/**`
`44`	`43`	`* Initialize a new extension installer`
`45`	`44`	`*`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function handle()`
`62`	`62`	`}`
`63`	`63`	`if ($INPUT->post->str('installurl')) {`
`64`	`64`	`$installer->installFromURL($INPUT->post->str('installurl'));`
`65`		`- } elseif (isset($_FILES['installfile'])) {`
	`65`	`+ } elseif (isset($_FILES['installfile']) && $_FILES['installfile']['error'] !== UPLOAD_ERR_NO_FILE) {`
`66`	`66`	`$installer->installFromUpload('installfile');`
`67`	`67`	`}`
`68`	`68`	`} catch (Exception $e) {`