JoinColumn attribute should be mark as Attribute::IS_REPEATABLE ?

[mar20]

It JoinColumn attribute should be mark as Attribute::IS_REPEATABLE ? When you add e.g

#[ORM\JoinColumn(nullable: false)] - wrong added line
#[ORM\JoinColumn(name: 'invoice_id', referencedColumnName: 'id', nullable: true)]

then then findOneBy(['invoice'=>$invoice]) - build wrong sql query with double invoice_id in where part

[derrabus]

I'm sorry, I don't understand the question.

[mar20]

#[Attribute(Attribute::TARGET_PROPERTY | Attribute::IS_REPEATABLE) **<---I ask about this part]** final class JoinColumn implements Annotation

[mar20]

Because when you add #[ORM\JoinColumn() twice working try use findOneBy it crash sql

[derrabus]

You need multiple join columns if the foreign entity has a composite primary key. So allowing this attribute to be repeatable looks correct to me.

[mar20]

ok, right. But may be better to use ORM\JoinColumns for this case ?

[derrabus]

No, JoinColumns is not an attribute.