Huge tests degradation after updating to doctrine/orm:3.5.0

[dmitryuk]

Hello. Anybody face same problem - after updating from doctrine/orm:3.4.4 to doctrine/orm:3.5.0 my phpunit tests (coverage enabled) become running 3x slower (12+ minutes vs 4 minute). I use https://github.com/dmaicher/doctrine-test-bundle and zenstruck/foundry

[beberlei]

@dmitryuk your projets phpunit tests, or the Doctrine Unit Tests? Without some profiling information this is a needle haystack search problem. Are you using native lazy objects with 8.4 or the Symfony Var Exporter based ones?

It would be helpful if you run this before and after with Tideways or php-spx (or any other see https://tideways.com/the-6-best-php-profilers).

[greg0ire]

You could try narrowing the issue down by applying this: https://dev.to/greg0ire/bisecting-vendors-12kd

[dmitryuk]

Give me a time, I will prepare a report or find a proper commit

[dmitryuk]

Finally I have found an issue commit
https://github.com/doctrine/orm/pull/12005/files#diff-b7c57c8fe4222bcf6ae806a98fb42f42434997ce6bdddbd37fcf1bf4fb005c2aR603

I I removed the condition in isNativeLazyObjectsEnabled everyting is fine, overwise - 3x slower.
While debugging the condition IDE will stop "million times and deprecation triggering decreases tests

[xabbuh]

So you should be able to see the previous performance again when enabling native lazy objects, right?

[dmitryuk]

Yes, it helped me. But anyway changes were not to be expected so and not easy to detect

[derrabus]

This method is executed quite often, so we probably flood the deprecation logs if a lot of proxies are generated. We should make sure the deprecation is only triggered once.