Why EntityManager does not implement EntityManagerInterface?

[michnovka]

It only implements the base ObjectManager.

because of differences in the ObjectManager::find:

public function find(string $className, $id);

and EntityManager::find:

public function find($entityName, $identifier, $lockMode = LockMode::NONE, $lockVersion = null)

I am getting issues with psalm then like this: psalm/psalm-plugin-symfony#274

Strangely, the EntityManagerInterface does not redefine the find() method, so it is also just with 2 arguments like the ObjectManager

Is there any reason why EntityManagerInterface doesnt copy exactly the signature of EntityManager, and also why EntityManager does not implement this interface?

[derrabus]

It only implements the base ObjectManager.

🤨

orm/lib/Doctrine/ORM/EntityManager.php

Line 76 in a8b02fd

class EntityManager implements EntityManagerInterface

Strangely, the EntityManagerInterface does not redefine the find() method, so it is also just with 2 arguments like the ObjectManager

These two parameters were added later and redefining and adding them to the interface would've been a breaking change. This is going to be fixed in ORM 3.0.

[michnovka]

I have absolutely no idea where I was looking into, it does indeed implement EntityManagerInterface... 🤦

Makes total sense to add them as default = null optional parameters only to the EntityManager class itself. Glad itll be added to the interface in 3.0.

Thanks