CI: Fix psalm by removing threading

ostrolucky · ostrolucky · commit a1b362757caa · 2024-02-20T22:57:01.000+01:00
Otherwise we get ``` Uncaught Exception: InvalidArgumentException Could not get class storage for doctrine\common\collections\selectable Emitted in /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Provider/ClassLikeStorageProvider.php:45 Stack trace in the forked worker: #0 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Codebase/ClassLikes.php(726): Psalm\Internal\Provider\ClassLikeStorageProvider->get() #1 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Codebase/ClassLikes.php(716): Psalm\Internal\Codebase\ClassLikes->getParentInterfaces() #2 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Codebase.php(763): Psalm\Internal\Codebase\ClassLikes->interfaceExtends() #3 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Type/Comparator/ObjectComparator.php(357): Psalm\Codebase->interfaceExtends() #4 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Type/Comparator/ObjectComparator.php(117): Psalm\Internal\Type\Comparator\ObjectComparator::isIntersectionShallowlyContainedBy() #5 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Type/Comparator/AtomicTypeComparator.php(350): Psalm\Internal\Type\Comparator\ObjectComparator::isShallowlyContainedBy() #6 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Type.php(891): Psalm\Internal\Type\Comparator\AtomicTypeComparator::isContainedBy() #7 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Type.php(768): Psalm\Type::intersectAtomicTypes() #8 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/PhpVisitor/Reflector/TypeHintResolver.php(112): Psalm\Type::intersectUnionTypes() #9 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeNodeScanner.php(405): Psalm\Internal\PhpVisitor\Reflector\TypeHintResolver::resolve() #10 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/PhpVisitor/ReflectorVisitor.php(207): Psalm\Internal\PhpVisitor\Reflector\FunctionLikeNodeScanner->start() #11 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(200): Psalm\Internal\PhpVisitor\ReflectorVisitor->enterNode() #12 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(114): PhpParser\NodeTraverser->traverseArray() #13 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(223): PhpParser\NodeTraverser->traverseNode() #14 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(114): PhpParser\NodeTraverser->traverseArray() #15 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(223): PhpParser\NodeTraverser->traverseNode() #16 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(91): PhpParser\NodeTraverser->traverseArray() #17 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Scanner/FileScanner.php(79): PhpParser\NodeTraverser->traverse() #18 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Codebase/Scanner.php(554): Psalm\Internal\Scanner\FileScanner->scan() #19 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Codebase/Scanner.php(782): Psalm\Internal\Codebase\Scanner->scanFile() #20 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Fork/Pool.php(191): Psalm\Internal\Codebase\Scanner->scanAPath() #21 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Codebase/Scanner.php(332): Psalm\Internal\Fork\Pool->__construct() #22 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Codebase/Scanner.php(280): Psalm\Internal\Codebase\Scanner->scanFilePaths() #23 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Codebase.php(505): Psalm\Internal\Codebase\Scanner->scanFiles() #24 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/ProjectAnalyzer.php(510): Psalm\Codebase->scanFiles() #25 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Cli/Psalm.php(374): Psalm\Internal\Analyzer\ProjectAnalyzer->check() #26 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/psalm(9): Psalm\Internal\Cli\Psalm::run() #27 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/bin/psalm(119): include('...') #28 {main} in /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Fork/Pool.php:379 Stack trace: #0 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Fork/Pool.php(413): Psalm\Internal\Fork\Pool->readResultsFromChildren() #1 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Codebase/Scanner.php(384): Psalm\Internal\Fork\Pool->wait() #2 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Codebase/Scanner.php(280): Psalm\Internal\Codebase\Scanner->scanFilePaths() #3 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Codebase.php(505): Psalm\Internal\Codebase\Scanner->scanFiles() #4 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/ProjectAnalyzer.php(510): Psalm\Codebase->scanFiles() #5 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/src/Psalm/Internal/Cli/Psalm.php(374): Psalm\Internal\Analyzer\ProjectAnalyzer->check() #6 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/vimeo/psalm/psalm(9): Psalm\Internal\Cli\Psalm::run() #7 /home/runner/work/DoctrineBundle/DoctrineBundle/vendor/bin/psalm(119): include('...') #8 {main} (Psalm 5.22.1@e9dad66e11274315dac27e08349c628c7d6a1a43 crashed due to an uncaught Throwable) ```
diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml
@@ -31,4 +31,4 @@ jobs:
         uses: "ramsey/composer-install@v2"
 
       - name: "Run a static analysis with vimeo/psalm"
-        run: "vendor/bin/psalm --show-info=false --stats --output-format=github --threads=$(nproc) --find-unused-psalm-suppress"
+        run: "vendor/bin/psalm --show-info=false --stats --output-format=github --find-unused-psalm-suppress"
diff --git a/DependencyInjection/DoctrineExtension.php b/DependencyInjection/DoctrineExtension.php
@@ -1136,7 +1136,6 @@ private function loadMessengerServices(ContainerBuilder $container): void
     {
         // If the Messenger component is installed, wire it:
 
-        /** @psalm-suppress UndefinedClass Optional dependency */
         if (! interface_exists(MessageBusInterface::class)) {
             return;
         }
diff --git a/Tests/DependencyInjection/DoctrineExtensionTest.php b/Tests/DependencyInjection/DoctrineExtensionTest.php
@@ -988,7 +988,6 @@ public function testAnnotationsBundleMappingDetectionWithVendorNamespace(): void
 
     public function testMessengerIntegration(): void
     {
-        /** @psalm-suppress UndefinedClass */
         if (! interface_exists(MessageBusInterface::class)) {
             $this->markTestSkipped('Symfony Messenger component is not installed');
         }
@@ -1014,7 +1013,6 @@ public function testMessengerIntegration(): void
 
     public function testMessengerIntegrationWithDoctrineTransport(): void
     {
-        /** @psalm-suppress UndefinedClass */
         if (! interface_exists(MessageBusInterface::class)) {
             $this->markTestSkipped('Symfony Messenger component is not installed');
         }
@@ -1046,7 +1044,6 @@ public function testMessengerIntegrationWithDoctrineTransport(): void
 
     public function testMessengerIntegrationWithoutDoctrineTransport(): void
     {
-        /** @psalm-suppress UndefinedClass */
         if (! interface_exists(MessageBusInterface::class)) {
             $this->markTestSkipped('Symfony Messenger component is not installed');
         }

Original file line number	Diff line number	Diff line change
`@@ -1136,7 +1136,6 @@ private function loadMessengerServices(ContainerBuilder $container): void`
`1136`	`1136`	`{`
`1137`	`1137`	`// If the Messenger component is installed, wire it:`
`1138`	`1138`
`1139`		`- /** @psalm-suppress UndefinedClass Optional dependency */`
`1140`	`1139`	`if (! interface_exists(MessageBusInterface::class)) {`
`1141`	`1140`	`return;`
`1142`	`1141`	`}`
Original file line number	Diff line number	Diff line change
`@@ -988,7 +988,6 @@ public function testAnnotationsBundleMappingDetectionWithVendorNamespace(): void`
`988`	`988`
`989`	`989`	`public function testMessengerIntegration(): void`
`990`	`990`	`{`
`991`		`- /** @psalm-suppress UndefinedClass */`
`992`	`991`	`if (! interface_exists(MessageBusInterface::class)) {`
`993`	`992`	`$this->markTestSkipped('Symfony Messenger component is not installed');`
`994`	`993`	`}`
`@@ -1014,7 +1013,6 @@ public function testMessengerIntegration(): void`
`1014`	`1013`
`1015`	`1014`	`public function testMessengerIntegrationWithDoctrineTransport(): void`
`1016`	`1015`	`{`
`1017`		`- /** @psalm-suppress UndefinedClass */`
`1018`	`1016`	`if (! interface_exists(MessageBusInterface::class)) {`
`1019`	`1017`	`$this->markTestSkipped('Symfony Messenger component is not installed');`
`1020`	`1018`	`}`
`@@ -1046,7 +1044,6 @@ public function testMessengerIntegrationWithDoctrineTransport(): void`
`1046`	`1044`
`1047`	`1045`	`public function testMessengerIntegrationWithoutDoctrineTransport(): void`
`1048`	`1046`	`{`
`1049`		`- /** @psalm-suppress UndefinedClass */`
`1050`	`1047`	`if (! interface_exists(MessageBusInterface::class)) {`
`1051`	`1048`	`$this->markTestSkipped('Symfony Messenger component is not installed');`
`1052`	`1049`	`}`