Skip to content

Commit 3948540

Browse files
committed
Fix or noqa B003 (assigning to os.environ doesn't do what you expect)
Signed-off-by: Aarni Koskela <akx@iki.fi>
1 parent 0566f12 commit 3948540

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

tests/integration/credentials/utils_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
@mock.patch.dict(os.environ)
88
def test_create_environment_dict():
99
base = {'FOO': 'bar', 'BAZ': 'foobar'}
10-
os.environ = base
10+
os.environ = base # noqa: B003
1111
assert create_environment_dict({'FOO': 'baz'}) == {
1212
'FOO': 'baz', 'BAZ': 'foobar',
1313
}

tests/unit/client_test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,8 @@ def setUp(self):
153153
self.os_environ = os.environ.copy()
154154

155155
def tearDown(self):
156-
os.environ = self.os_environ
156+
os.environ.clear()
157+
os.environ.update(self.os_environ)
157158

158159
def test_from_env(self):
159160
"""Test that environment variables are passed through to

tests/unit/utils_test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ def setUp(self):
5959
self.os_environ = os.environ.copy()
6060

6161
def tearDown(self):
62-
os.environ = self.os_environ
62+
os.environ.clear()
63+
os.environ.update(self.os_environ)
6364

6465
def test_kwargs_from_env_empty(self):
6566
os.environ.update(DOCKER_HOST='',

0 commit comments

Comments
 (0)