Skip to content

Commit 3783253

Browse files
authored
integration: Fix bad subnet declaration (#3169)
Some network integration tests are creating networks with subnet `2001:389::1/64`. This is an invalid subnet as the host fragment is non-zero (ie. it should be `2001:389::/64`). PR moby/moby#45759 is adding strict validation of network configuration. Docker API will now return an error whenever a bad subnet is passed. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
1 parent 0f0b20a commit 3783253

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tests/integration/api_network_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ def test_create_with_ipv6_address(self):
233233
net_name, net_id = self.create_network(
234234
ipam=IPAMConfig(
235235
driver='default',
236-
pool_configs=[IPAMPool(subnet="2001:389::1/64")],
236+
pool_configs=[IPAMPool(subnet="2001:389::/64")],
237237
),
238238
)
239239
container = self.client.create_container(
@@ -389,7 +389,7 @@ def test_connect_with_ipv6_address(self):
389389
driver='default',
390390
pool_configs=[
391391
IPAMPool(
392-
subnet="2001:389::1/64", iprange="2001:389::0/96",
392+
subnet="2001:389::/64", iprange="2001:389::0/96",
393393
gateway="2001:389::ffff"
394394
)
395395
]
@@ -455,7 +455,7 @@ def test_create_network_ipv6_enabled(self):
455455
driver='default',
456456
pool_configs=[
457457
IPAMPool(
458-
subnet="2001:389::1/64", iprange="2001:389::0/96",
458+
subnet="2001:389::/64", iprange="2001:389::0/96",
459459
gateway="2001:389::ffff"
460460
)
461461
]

0 commit comments

Comments
 (0)