From 460c1f8e7a89fff1666139d515e83bd2ebaf6ff7 Mon Sep 17 00:00:00 2001 From: JkktBkkt <101349225+JkktBkkt@users.noreply.github.com> Date: Thu, 16 May 2024 12:47:16 +0300 Subject: [PATCH] Fixed version check from checking if the version is less than 3.6 and then not'ing the result of the check. Current version was: if not sys.version_info < (3, 6) -> exit let's test this: Ex. 1 sys.version_info = (3, 5) sys.version_info < (3, 6) ? true not sys.version_info < (3, 6) ? false -> try continuing the installation as normal Ex. 2 sys.version_info = (3, 10) sys.version_info < (3, 6) ? false not sys.version_info < (3, 6) ? true -> exit, error message "Python 3.6 or newer is required" If 3.6 or newer is required, the 'not' in the check is breaking it. Admittedly, most users probably stay on the release version. Still, this shouldn't be so obviously and easily fixable imo. --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index f592114..ce45895 100644 --- a/setup.py +++ b/setup.py @@ -4,7 +4,7 @@ import sys, os, re, subprocess as sp from setuptools import setup -if not sys.version_info < (3, 6): +if sys.version_info < (3, 6): sys.exit("Python 3.6 or newer is required.") ########################################