Added ExceptionAssert to get a better error message when the exception message does not contain the expected message.

Author: dlemstra

tests/Magick.NET.Tests/Coders/TheMapCoder.cs

@@ -42,7 +42,7 @@ public void ShouldThrowExceptionWhenDimensionsNotSpecified(uint? width, uint? he
         using var image = new MagickImage();
 
         var exception = Assert.Throws<MagickOptionErrorException>(() => image.Read(tempFile.File, settings));
-        Assert.Contains("must specify image size", exception.Message);
+        ExceptionAssert.Contains("must specify image size", exception);
     }
 
     [Fact]
@@ -58,7 +58,7 @@ public void ShouldThrowExceptionWhenDepthNotSpecified()
         using var image = new MagickImage();
 
         var exception = Assert.Throws<MagickOptionErrorException>(() => image.Read(tempFile.File, settings));
-        Assert.Contains("must specify image depth", exception.Message);
+        ExceptionAssert.Contains("must specify image depth", exception);
     }
 
     [Fact]

tests/Magick.NET.Tests/Coders/TheTiffCoder.cs

@@ -19,7 +19,7 @@ public void ShouldThrowExceptionWhenImageContainsInvalidTag()
 
         var exception = Assert.Throws<MagickCoderErrorException>(() => image.Read(Files.Coders.IgnoreTagTIF));
 
-        Assert.Contains(@$"Null count for ""Tag {_tag}""", exception.Message);
+        ExceptionAssert.Contains(@$"Null count for ""Tag {_tag}""", exception);
     }
 
     [Fact]
@@ -31,7 +31,7 @@ public void ShouldIgnoreTheSpecifiedTags()
 
         var settings = new MagickReadSettings(new TiffReadDefines
         {
-            IgnoreTags = new string[] { _tag },
+            IgnoreTags = [_tag],
         });
 
         image.Settings.RemoveDefine(MagickFormat.Tiff, "ignore-tags");

tests/Magick.NET.Tests/Formats/Bmp/BmpReadDefinesTests/TheIgnoreFileSizeProperty.cs

@@ -62,7 +62,7 @@ public void ShouldNotAllowReadingBmpWithInvalidFileSizeByDefault()
             image.Settings.SetDefines(defines);
 
             var exception = Assert.Throws<MagickCorruptImageErrorException>(() => image.Read(Files.Coders.InvalidCrcBMP));
-            Assert.Contains("length and filesize do not match", exception.Message);
+            ExceptionAssert.Contains("length and filesize do not match", exception);
         }
     }
 }

tests/Magick.NET.Tests/Formats/Pdf/PdfInfoTests/TheCreateMethod.cs

@@ -74,12 +74,12 @@ public void ShouldThrowExceptionWhenFileIsPng()
 
                 if (exception is MagickDelegateErrorException delegateErrorException)
                 {
-                    Assert.Single(exception.RelatedExceptions);
-                    Assert.Contains("Error: /syntaxerror in pdfopen", exception.RelatedExceptions.First().Message);
+                    Assert.Single(delegateErrorException.RelatedExceptions);
+                    ExceptionAssert.Contains("Error: /syntaxerror in pdfopen", delegateErrorException);
                 }
                 else
                 {
-                    Assert.Contains("Unable to determine the page count.", exception.Message);
+                    ExceptionAssert.Contains("Unable to determine the page count.", exception);
                 }
             }
         }

tests/Magick.NET.Tests/Formats/Pdf/PdfReadDefinesTests/ThePasswordProperty.cs

@@ -76,13 +76,7 @@ public void ShouldNotBeAbleToOpenFileWithNullPassword()
             }
             catch (MagickDelegateErrorException exception)
             {
-                var message = exception.Message;
-
-                var relatedException = exception.RelatedExceptions.FirstOrDefault();
-                if (relatedException is not null)
-                    message += relatedException.Message;
-
-                Assert.Contains("This file requires a password for access.", message);
+                ExceptionAssert.Contains("This file requires a password for access.", exception);
                 return;
             }
 

tests/Magick.NET.Tests/Helpers/StreamWrapperTests/TheCreateForReadingMethod.cs

@@ -17,7 +17,7 @@ public void ShouldThrowExceptionWhenStreamIsNotReadable()
             using var stream = TestStream.ThatCannotRead();
 
             var exception = Assert.Throws<ArgumentException>("stream", () => StreamWrapper.CreateForReading(stream));
-            Assert.Contains("readable", exception.Message);
+            ExceptionAssert.Contains("readable", exception);
         }
 
         [Fact]

tests/Magick.NET.Tests/Helpers/StreamWrapperTests/TheCreateForWritingMethod.cs

@@ -17,7 +17,7 @@ public void ShouldThrowExceptionWhenStreamIsNotWritable()
             using var stream = TestStream.ThatCannotWrite();
 
             var exception = Assert.Throws<ArgumentException>("stream", () => StreamWrapper.CreateForWriting(stream));
-            Assert.Contains("writable", exception.Message);
+            ExceptionAssert.Contains("writable", exception);
         }
 
         [Fact]

tests/Magick.NET.Tests/MagickImageCollectionTests/TheAddRangeMethod.cs

@@ -159,7 +159,7 @@ public void ShouldThrowExceptionWhenInvalid()
                 using var images = new MagickImageCollection();
                 var exception = Assert.Throws<MagickBlobErrorException>(() => images.Add(Files.Missing));
 
-                Assert.Contains("error/blob.c/OpenBlob", exception.Message);
+                ExceptionAssert.Contains("error/blob.c/OpenBlob", exception);
             }
 
             [Fact]

tests/Magick.NET.Tests/MagickImageCollectionTests/TheConstructor.cs

@@ -239,7 +239,7 @@ public void ShouldThrowExceptionWhenFileNameIsInvalid()
             {
                 var exception = Assert.Throws<MagickBlobErrorException>(() => new MagickImageCollection(Files.Missing));
 
-                Assert.Contains("error/blob.c/OpenBlob", exception.Message);
+                ExceptionAssert.Contains("error/blob.c/OpenBlob", exception);
             }
 
             [Fact]

tests/Magick.NET.Tests/MagickImageCollectionTests/ThePingMethod.cs

@@ -210,7 +210,7 @@ public void ShouldThrowExceptionWhenFileNameIsInvalid()
                 using var images = new MagickImageCollection();
 
                 var exception = Assert.Throws<MagickBlobErrorException>(() => images.Ping(Files.Missing));
-                Assert.Contains("error/blob.c/OpenBlob", exception.Message);
+                ExceptionAssert.Contains("error/blob.c/OpenBlob", exception);
             }
 
             [Fact]