Improved the big rational implementation by checking for values above long.MaxValue and values that have zero as the fractional part.

Author: dlemstra

src/Magick.NET.Core/Types/BigRational.cs

@@ -44,6 +44,20 @@ public BigRational(double value, bool bestPrecision)
             return;
         }
 
+        if (value >= long.MaxValue)
+        {
+            Numerator = long.MaxValue;
+            Denominator = 1;
+            return;
+        }
+
+        if (Math.Floor(value) == value)
+        {
+            Numerator = (long)value;
+            Denominator = 1;
+            return;
+        }
+
         Numerator = 1;
         Denominator = 1;
 

tests/Magick.NET.Core.Tests/Types/RationalTests/TheConstructor.cs

@@ -63,5 +63,14 @@ public void ShouldHandleZeroValue()
             Assert.Equal(0U, rational.Numerator);
             Assert.Equal(1U, rational.Denominator);
         }
+
+        [Fact]
+        public void ShouldClampTheValue()
+        {
+            var rational = new Rational(long.MaxValue * 100.0);
+
+            Assert.Equal(uint.MaxValue, rational.Numerator);
+            Assert.Equal(1U, rational.Denominator);
+        }
     }
 }

tests/Magick.NET.Core.Tests/Types/SignedRationalTests/TheConstructor.cs

@@ -63,5 +63,14 @@ public void ShouldHandleZeroValue()
             Assert.Equal(0, rational.Numerator);
             Assert.Equal(1, rational.Denominator);
         }
+
+        [Fact]
+        public void ShouldClampTheValue()
+        {
+            var rational = new SignedRational(long.MaxValue * 100.0);
+
+            Assert.Equal(-1, rational.Numerator);
+            Assert.Equal(1, rational.Denominator);
+        }
     }
 }