Simplify core.stdc.string : strerror_r definition

Author: Geod24

src/core/stdc/string.d

@@ -23,6 +23,12 @@ else version (TVOS)
 else version (WatchOS)
     version = Darwin;
 
+// Those libs don't expose the mandated C interface
+version (CRuntime_Glibc)
+    version = ReturnStrerrorR;
+else version (CRuntime_UClibc)
+    version = ReturnStrerrorR;
+
 extern (C):
 @system:
 nothrow:
@@ -44,26 +50,30 @@ void* memmove(return void* s1, scope const void* s2, size_t n) pure;
 ///
 void* memset(return void* s, int c, size_t n) pure;
 
-///
-char*  strcpy(return char* s1, scope const char* s2) pure;
-///
-char*  strncpy(return char* s1, scope const char* s2, size_t n) pure;
 ///
 char*  strcat(return char* s1, scope const char* s2) pure;
 ///
-char*  strncat(return char* s1, scope const char* s2, size_t n) pure;
+inout(char)*  strchr(return inout(char)* s, int c) pure;
 ///
 int    strcmp(scope const char* s1, scope const char* s2) pure;
 ///
 int    strcoll(scope const char* s1, scope const char* s2);
 ///
-int    strncmp(scope const char* s1, scope const char* s2, size_t n) pure;
+char*  strcpy(return char* s1, scope const char* s2) pure;
 ///
-size_t strxfrm(scope char* s1, scope const char* s2, size_t n);
+size_t strcspn(scope const char* s1, scope const char* s2) pure;
 ///
-inout(char)*  strchr(return inout(char)* s, int c) pure;
+char*  strdup(scope const char *s);
 ///
-size_t strcspn(scope const char* s1, scope const char* s2) pure;
+char*  strerror(int errnum);
+///
+char*  strncpy(return char* s1, scope const char* s2, size_t n) pure;
+///
+char*  strncat(return char* s1, scope const char* s2, size_t n) pure;
+///
+int    strncmp(scope const char* s1, scope const char* s2, size_t n) pure;
+///
+size_t strxfrm(scope char* s1, scope const char* s2, size_t n);
 ///
 inout(char)*  strpbrk(return inout(char)* s1, scope const char* s2) pure;
 ///
@@ -74,53 +84,17 @@ size_t strspn(scope const char* s1, scope const char* s2) pure;
 inout(char)*  strstr(return inout(char)* s1, scope const char* s2) pure;
 ///
 char*  strtok(return char* s1, scope const char* s2);
-///
-char*  strerror(int errnum);
-version (CRuntime_Glibc)
+// This `strerror_r` definition is not following the POSIX standard
+version (ReturnStrerrorR)
 {
     ///
     const(char)* strerror_r(int errnum, return char* buf, size_t buflen);
 }
-else version (Darwin)
-{
-    int strerror_r(int errnum, scope char* buf, size_t buflen);
-}
-else version (FreeBSD)
-{
-    int strerror_r(int errnum, scope char* buf, size_t buflen);
-}
-else version (NetBSD)
-{
-    int strerror_r(int errnum, char* buf, size_t buflen);
-}
-else version (OpenBSD)
-{
-    int strerror_r(int errnum, scope char* buf, size_t buflen);
-}
-else version (DragonFlyBSD)
-{
-    int strerror_r(int errnum, scope char* buf, size_t buflen);
-}
-else version (Solaris)
-{
-    int strerror_r(int errnum, scope char* buf, size_t buflen);
-}
-else version (CRuntime_Bionic)
+// This one is
+else
 {
     ///
     int strerror_r(int errnum, scope char* buf, size_t buflen);
 }
-else version (CRuntime_Musl)
-{
-    ///
-    int strerror_r(int errnum, scope char *buf, size_t buflen);
-}
-else version (CRuntime_UClibc)
-{
-    ///
-    const(char)* strerror_r(int errnum, return char* buf, size_t buflen);
-}
 ///
 size_t strlen(scope const char* s) pure;
-///
-char*  strdup(scope const char *s);