Merge pull request #3045 from MoonlightSentinel/nullToString

Fix Issue 20750 - checkaction=context segfaults for null references
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

Author: dlang-bot

src/core/internal/dassert.d

@@ -111,14 +111,21 @@ private string miniFormat(V)(const ref V v)
     {
         return "`null`";
     }
-    else static if (__traits(compiles, { string s = v.toString(); }))
-    {
-        return v.toString();
-    }
-    // Non-const toString(), e.g. classes inheriting from Object
+    // toString() isn't always const, e.g. classes inheriting from Object
     else static if (__traits(compiles, { string s = V.init.toString(); }))
     {
-        return (cast() v).toString();
+        // Object references / struct pointers may be null
+        static if (is(V == class) || is(V == interface) || is(V == U*, U))
+        {
+            if (v is null)
+                return "`null`";
+        }
+
+        // Prefer const overload of toString
+        static if (__traits(compiles, { string s = v.toString(); }))
+            return v.toString();
+        else
+            return (cast() v).toString();
     }
     // Static arrays or slices (but not aggregates with `alias this`)
     else static if (is(V : U[], U) && !isAggregateType!V)

test/exceptions/src/assert_fail.d

@@ -98,6 +98,9 @@ void testToString()()
     }
 
     test!"!="(Overloaded(), Overloaded(), "Const == Const");
+
+    Foo fnull = null;
+    test!"!is"(fnull, fnull, "`null` is `null`");
 }