Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Commit 67618bd

Browse files
authored
Merge pull request #3129 from quickfur/issue20910
Fix issue 20910: fix misleading unittest runner messages. merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
2 parents 246d15a + c3be38c commit 67618bd

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/rt/dmain2.d

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ private extern (C) int _d_run_main2(char[][] args, size_t totalArgsLength, MainF
560560
if (utResult.passed == 0)
561561
.fprintf(.stderr, "No unittests run\n");
562562
else
563-
.fprintf(.stderr, "%d unittests passed\n",
563+
.fprintf(.stderr, "%d modules passed unittests\n",
564564
cast(int)utResult.passed);
565565
}
566566
if (utResult.runMain)
@@ -571,7 +571,7 @@ private extern (C) int _d_run_main2(char[][] args, size_t totalArgsLength, MainF
571571
else
572572
{
573573
if (utResult.summarize)
574-
.fprintf(.stderr, "%d/%d unittests FAILED\n",
574+
.fprintf(.stderr, "%d/%d modules FAILED unittests\n",
575575
cast(int)(utResult.executed - utResult.passed),
576576
cast(int)utResult.executed);
577577
result = EXIT_FAILURE;

test/unittest/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ $(ROOT)/%.done: customhandler.d
3838
$(QUIET)$(TIMELIMIT)$(ROOT)/tester_$(patsubst %.done,%, $(notdir $@)) > $@ 2>&1; test $$? -eq $(RETCODE)
3939
$(QUIET)test $(HASMAIN) -eq 0 || grep -q main $@
4040
$(QUIET)test $(HASMAIN) -eq 1 || ! grep -q main $@
41-
$(QUIET)test -z "$(TESTTEXT)" || grep -q "unittests $(TESTTEXT)" $@
41+
$(QUIET)test -z "$(TESTTEXT)" || grep -q "$(TESTTEXT) unittests" $@
4242
$(QUIET)test -n "$(TESTTEXT)" || ! grep -q "unittests" $@
4343
clean:
4444
rm -rf $(GENERATED)

0 commit comments

Comments
 (0)