Merge pull request #2305 from ibuclaw/bshedparens

[refactor] posix.mak: Enforce whitespace before opening parenthesis
merged-on-behalf-of: Petar Kirov <ZombineDev@users.noreply.github.com>

Author: dlang-bot

posix.mak

@@ -371,6 +371,9 @@ style_lint:
 	@echo "Check for trailing whitespace"
 	$(GREP) -nr '[[:blank:]]$$' $(MANIFEST) ; test $$? -eq 1
 
+	@echo "Enforce whitespace before opening parenthesis"
+	grep -nrE "\<(for|foreach|foreach_reverse|if|while|switch|catch)\(" $$(find src -name '*.d') ; test $$? -eq 1
+
 .PHONY : auto-tester-build
 auto-tester-build: target checkwhitespace
 

src/core/atomic.d

@@ -169,7 +169,7 @@ If forward is false, bsr is computed (the index of the last set bit).
 -1 is returned if no bits are set (v == 0).
 */
 private int softScan(N, bool forward)(N v) pure
-    if(is(N == uint) || is(N == ulong))
+    if (is(N == uint) || is(N == ulong))
 {
     // bsf() and bsr() are officially undefined for v == 0.
     if (!v)
@@ -251,7 +251,7 @@ unittest
 
     foreach (b; 0 .. 64)
     {
-        if(b < 32)
+        if (b < 32)
         {
             assert(softBsf!uint(1u << b) == b);
             assert(softBsr!uint(1u << b) == b);
@@ -415,7 +415,7 @@ struct BitRange
         // clear the current bit
         auto curbit = idx % bitsPerWord;
         cur ^= size_t(1) << curbit;
-        if(!cur)
+        if (!cur)
         {
             // find next size_t with set bit
             idx -= curbit;
@@ -458,7 +458,7 @@ struct BitRange
     // iterate
     size_t testSum;
     size_t nBits;
-    foreach(b; BitRange(bitArr, 100))
+    foreach (b; BitRange(bitArr, 100))
     {
         testSum += b;
         ++nBits;
@@ -478,10 +478,10 @@ struct BitRange
         size_t* bitArr = cast(size_t *)malloc(numBytes);
         scope(exit) free(bitArr);
         memset(bitArr, 0, numBytes);
-        foreach(b; bitsToTest)
+        foreach (b; bitsToTest)
             bts(bitArr, b);
         auto br = BitRange(bitArr, numBits);
-        foreach(b; bitsToTest)
+        foreach (b; bitsToTest)
         {
             assert(!br.empty);
             assert(b == br.front);
@@ -796,7 +796,7 @@ unittest
     static void test(alias impl)()
     {
         assert (impl( 0x8000_0100 ) == 0x0080_0001);
-        foreach(i; 0 .. 32)
+        foreach (i; 0 .. 32)
             assert (impl(1 << i) == 1 << 32 - i - 1);
     }
 

src/core/bitop.d

@@ -572,7 +572,7 @@ long muls(long x, long y, ref bool overflow)
 {
     immutable long r = cast(ulong)x * cast(ulong)y;
     enum not0or1 = ~1L;
-    if((x & not0or1) && ((r == y)? r : (r / x) != y))
+    if ((x & not0or1) && ((r == y)? r : (r / x) != y))
         overflow = true;
     return r;
 }
@@ -608,7 +608,7 @@ cent muls(cent x, cent y, ref bool overflow)
 {
     immutable cent r = cast(ucent)x * cast(ucent)y;
     enum not0or1 = ~1L;
-    if((x & not0or1) && ((r == y)? r : (r / x) != y))
+    if ((x & not0or1) && ((r == y)? r : (r / x) != y))
         overflow = true;
     return r;
 }

src/core/checkedint.d

@@ -551,7 +551,7 @@ void getcacheinfoCPUID2()
 void getcacheinfoCPUID4()
 {
     int cachenum = 0;
-    for(;;) {
+    for (;;) {
         uint a, b, number_of_sets;
         version(GNU) asm pure nothrow @nogc {
             "cpuid" : "=a" a, "=b" b, "=c" number_of_sets : "a" 4, "c" cachenum : "edx";