-
-
Notifications
You must be signed in to change notification settings - Fork 14
Auto merge
Sebastian Wilzbach edited this page Dec 17, 2016
·
10 revisions
- Auth via oAuth
- Problematic as we would need to store all OAuth token for all members of @dlang
- Heroku isn't a safe place for such critical write-access tokens
- Running our own server for dlang-bot is an overkill (atm)
- Only users with write permissions can add labels
- Let dlang-bot do the merge
Options:
a) cache label + status events & put the open PRs in a database -> update database on new Problem 1: we might miss an event
b) on every request: query GH API for label & CI status (2 requests) Problem 1: we might overuse the API and run in rate limitations
c) have a cron job that checks for mergeable PRs every X minutes