Skip to content
Sebastian Wilzbach edited this page Dec 17, 2016 · 10 revisions
  1. Auth via oAuth

  • Problematic as we would need to store all OAuth token for all members of @dlang
  • Heroku isn't a safe place for such critical write-access tokens
  • Running our own server for dlang-bot is an overkill (atm)

2a) Auth via labels

  • Only users with write permissions can add labels
  • Let dlang-bot do the merge

Options:

2a) cache label + status events & put the open PRs in a database

-> update database on new events

Problem 1: we might miss an event

2b) on every request: query GH API for label & CI status (2 requests)

Problem 1: we might overuse the API and run in rate limitations

2c) have a cron job that checks for mergeable PRs every X minutes

Problem 1: we might need to send multiple requests as we need to loop over all open PRs and the API only returns 100 results per query Problem 2: we need to ignore potentially failing CIs like CodeCov

Clone this wiki locally