Add test

Author: fsbraun

djangocms_text/cms_plugins.py

@@ -48,6 +48,7 @@
 from cms.utils.urlutils import admin_reverse
 
 from . import settings
+from .editors import get_editor_config
 from .forms import ActionTokenValidationForm, RenderPluginForm, TextForm
 from .html import render_dynamic_attributes
 from .models import Text, _MAX_RTE_LENGTH
@@ -62,7 +63,10 @@
     random_comment_exempt,
     replace_plugin_tags,
 )
-from .widgets import TextEditorWidget, rte_config
+from .widgets import TextEditorWidget
+
+
+rte_config = get_editor_config()
 
 
 def post_add_plugin(operation, **kwargs):

djangocms_text/cms_toolbars.py

@@ -12,8 +12,12 @@
 from cms.toolbar_pool import toolbar_pool
 
 from . import settings
+from .editors import get_editor_config
 from .utils import get_cancel_url, get_messages_url, get_render_plugin_url
-from .widgets import TextEditorWidget, get_url_endpoint, rte_config
+from .widgets import TextEditorWidget, get_url_endpoint
+
+
+rte_config = get_editor_config()
 
 
 class IconButton(Button):

djangocms_text/contrib/text_ckeditor4/static/djangocms_text/js/basepath.js

@@ -1 +1,6 @@
-   window.CKEDITOR_BASEPATH = JSON.parse(document.getElementById('cms-editor-cfg').textContent).CKEDITOR_BASEPATH;
+// CKEDITOR_BASEPATH is setting for CKEditor 4 which reveals the base path from which to load config etc.
+// It can be configred by the TEXT_CKEDITOR_BASEPATH setting in the Django settings file.
+// It's loaded in this script since we avoid inline scripts (to better support CSP headers) and it needs to be
+// set before the CKEditor script is loaded which in turn needs to be loaded before the integration script.
+
+window.CKEDITOR_BASEPATH = JSON.parse(document.getElementById('cms-editor-cfg').textContent).CKEDITOR_BASEPATH;

djangocms_text/widgets.py

@@ -18,9 +18,6 @@
 from .editors import DEFAULT_TOOLBAR_CMS, DEFAULT_TOOLBAR_HTMLField, get_editor_base_config, get_editor_config
 from .utils import admin_reverse, cms_placeholder_add_plugin
 
-rte_config = get_editor_config()
-#: The configuration for the text editor widget
-
 
 @cache
 def get_url_endpoint():
@@ -224,6 +221,7 @@ def get_installed_plugins(self):
     def get_global_settings(self, language):
         """The global settings are shared by all widgets and are the same for all instances. They only need
         to be loaded once."""
+        rte_config = get_editor_config()
         # Get the toolbar setting
         toolbar_setting = get_editor_base_config()
         for plugin in self.installed_plugins:

tests/integration/test_ckeditor4.py

@@ -1,3 +1,4 @@
+import json
 import pytest
 from cms.utils.urlutils import admin_reverse
 from playwright.sync_api import expect
@@ -30,6 +31,13 @@ def handle_console_message(msg):
 
     page.goto(f"{live_server.url}{admin_reverse('cms_placeholder_edit_plugin', args=(text_plugin.pk,))}")
 
+    editor_config = json.loads(
+        page.locator("#cms-editor-cfg").text_content()
+    )  # Ensure the editor configuration is loaded
+    print(editor_config)  # Debugging output
+    assert "CKEDITOR_BASEPATH" in editor_config, "CKEDITOR_BASEPATH not found in editor configuration"
+    assert editor_config["CKEDITOR_BASEPATH"] == "/static/djangocms_text/vendor/ckeditor4/"
+
     editor = page.locator(".cke.cke_reset")
     expect(editor).to_be_visible()  # Editor