fix: Adding text-enabled plugins failed after second

Author: fsbraun

README.rst

@@ -66,7 +66,7 @@ from djangocms-text-ckeditor, and clean up old tables. All you have to do is:
 * add ``djangocms_text`` to ``INSTALLED_APPS`` (see above)
 * run ``python -m manage migrate djangocms_text``
 
-**Attention**: The migration command also deletes djangocms-text-ckeditor's 
+**Attention**: The migration command also deletes djangocms-text-ckeditor's
 tables from the database (to avoid referential integrity issues). To be on
 the safe side, make a backup of its content.
 

private/js/cms.editor.js

@@ -521,7 +521,7 @@ class CMSEditor {
             cms_history: 0,
         };
         const url = `${settings.add_plugin_url}?${new URLSearchParams(data).toString()}`;
-        return this.loadForm(url, iframe, el, onLoad, onSave);
+        return this.loadPluginForm(url, iframe, el, onLoad, onSave);
     }
 
     // CMS Editor: addPluginForm
@@ -535,10 +535,10 @@ class CMSEditor {
             cms_history: 0,
         };
         url = `${url}?${new URLSearchParams(data).toString()}`;
-        return this.loadForm(url, iframe, el, onLoad, onSave);
+        return this.loadPluginForm(url, iframe, el, onLoad, onSave);
     }
 
-    loadForm (url, iframe, el, onLoad, onSave) {
+    loadPluginForm (url, iframe, el, onLoad, onSave) {
         iframe.addEventListener('load', () => {
             const form = iframe.contentDocument;
             const heading = form.querySelector('#content h1');
@@ -565,9 +565,7 @@ class CMSEditor {
                 // Hook into the django CMS dataBridge to get the details of the newly created or saved
                 // plugin. For new plugins we need their id to get the content.
 
-                if (!this.CMS.API.Helpers.dataBridge) {
-                    this.processDataBridge(form);
-                }
+                this.processDataBridge(form);
                 // Needed to update StructureBoard
                 if (onSave && this.CMS.API.Helpers.dataBridge) {
                     onSave(el, form, this.CMS.API.Helpers.dataBridge);

tests/js/cms.editor.test.js

@@ -65,7 +65,7 @@ describe('CMSEditor', () => {
         const el = document.getElementById('editor1');
         document.body.appendChild(iframe);
 
-        editor.loadForm('about:blank', iframe, el, () => {
+        editor.loadPluginForm('about:blank', iframe, el, () => {
             expect(iframe.contentDocument).toBeTruthy();
             done();
         });