From 4f25334526b7483aab7c2ad07d372d5e835a1588 Mon Sep 17 00:00:00 2001 From: anandre <38661761+anandre@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:05:58 -0500 Subject: [PATCH 1/5] Update InteractionResponses.js Update the parameters for the showModal method --- .../src/structures/interfaces/InteractionResponses.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/discord.js/src/structures/interfaces/InteractionResponses.js b/packages/discord.js/src/structures/interfaces/InteractionResponses.js index 636f7310e5ac..535764929743 100644 --- a/packages/discord.js/src/structures/interfaces/InteractionResponses.js +++ b/packages/discord.js/src/structures/interfaces/InteractionResponses.js @@ -245,7 +245,7 @@ class InteractionResponses { /** * Shows a modal component - * @param {APIModal|ModalData|Modal} modal The modal to show + * @param {APIModalInteractionResponseCallbackData|ModalBuilder} modal The modal to show * @returns {Promise} */ async showModal(modal) { From 3baf9f3fa9ee326aea9957e9c155b8406624ffa4 Mon Sep 17 00:00:00 2001 From: anandre <38661761+anandre@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:12:35 -0500 Subject: [PATCH 2/5] Update APITypes.js Add APIModalInteractionResponseCallbackData link for docs link for showModal method --- packages/discord.js/src/util/APITypes.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/discord.js/src/util/APITypes.js b/packages/discord.js/src/util/APITypes.js index 3a4878e2d4d9..8764c155a241 100644 --- a/packages/discord.js/src/util/APITypes.js +++ b/packages/discord.js/src/util/APITypes.js @@ -133,6 +133,11 @@ * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/interface/APIModalInteractionResponse} */ +/** + * @external APIModalInteractionResponseCallbackData + * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/interface/APIModalInteractionResponseCallbackData} + */ + /** * @external APIModalComponent * @see {@link https://discord-api-types.dev/api/discord-api-types-v10#APIModalComponent} From 57ffcc4089f20799fb93483050190e0b1e957637 Mon Sep 17 00:00:00 2001 From: anandre <38661761+anandre@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:20:58 -0500 Subject: [PATCH 3/5] Update InteractionResponses.js Change the order of parameters so the ModalBuilder is listed first --- .../src/structures/interfaces/InteractionResponses.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/discord.js/src/structures/interfaces/InteractionResponses.js b/packages/discord.js/src/structures/interfaces/InteractionResponses.js index 535764929743..f027c3bade97 100644 --- a/packages/discord.js/src/structures/interfaces/InteractionResponses.js +++ b/packages/discord.js/src/structures/interfaces/InteractionResponses.js @@ -245,7 +245,7 @@ class InteractionResponses { /** * Shows a modal component - * @param {APIModalInteractionResponseCallbackData|ModalBuilder} modal The modal to show + * @param {ModalBuilder|APIModalInteractionResponseCallbackData} modal The modal to show * @returns {Promise} */ async showModal(modal) { From 8631a3a676606f1f670c7b48e4bf219f08e892b3 Mon Sep 17 00:00:00 2001 From: anandre <38661761+anandre@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:22:26 -0500 Subject: [PATCH 4/5] Update APITypes.js Disable the ESline line length rule for the APITypes file --- packages/discord.js/src/util/APITypes.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/discord.js/src/util/APITypes.js b/packages/discord.js/src/util/APITypes.js index 8764c155a241..080df51616a2 100644 --- a/packages/discord.js/src/util/APITypes.js +++ b/packages/discord.js/src/util/APITypes.js @@ -1,3 +1,5 @@ +/* eslint-disable max-len */ + /** * @external ActivityFlags * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/enum/ActivityFlags} From b6d9957a24a317ed6ada59dc1a0a138265601900 Mon Sep 17 00:00:00 2001 From: anandre <38661761+anandre@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:44:33 -0500 Subject: [PATCH 5/5] Update InteractionResponses.js Add ModalComponentData to the JSDoc, it was omitted before. --- .../src/structures/interfaces/InteractionResponses.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/discord.js/src/structures/interfaces/InteractionResponses.js b/packages/discord.js/src/structures/interfaces/InteractionResponses.js index f027c3bade97..d846ac7166bd 100644 --- a/packages/discord.js/src/structures/interfaces/InteractionResponses.js +++ b/packages/discord.js/src/structures/interfaces/InteractionResponses.js @@ -245,7 +245,7 @@ class InteractionResponses { /** * Shows a modal component - * @param {ModalBuilder|APIModalInteractionResponseCallbackData} modal The modal to show + * @param {ModalBuilder|ModalComponentData|APIModalInteractionResponseCallbackData} modal The modal to show * @returns {Promise} */ async showModal(modal) {