Skip to content

Commit 1306b4c

Browse files
committed
Desultory improvements.
Killing tasks in the error handling must be done carefully, and given this testing session it seems better to refrain from doing it when erroring out at COPY init time (missing column is an example of that). The approach around that is still very much ad-hoc rather than systematic. In passing improve the `make save` option to producing a binary image: have the make recipe respect the CL variable. The command line options differences were already accounted for.
1 parent 2147a1d commit 1306b4c

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ test: $(PGLOADER)
165165
$(MAKE) PGLOADER=$(realpath $(PGLOADER)) CL=$(CL) -C test regress
166166

167167
save: ./src/save.lisp $(LISP_SRC)
168-
sbcl --no-userinit --load ./src/save.lisp
168+
$(CL) $(CL_OPTS) --load ./src/save.lisp
169169

170170
check-saved: save
171171
$(MAKE) PGLOADER=$(realpath $(PGLOADER)) CL=$(CL) -C test regress

src/load/copy-data.lisp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@
7979
#'(lambda (condition)
8080
;; stop the other tasks and then transfer the control
8181
(log-message :log "COPY INIT ERROR")
82-
(lp:kill-tasks :default)
8382
(lp:invoke-transfer-error condition)))
8483
(on-error-stop
8584
#'(lambda (condition)

0 commit comments

Comments
 (0)