Skip to content

Commit 91fe9d1

Browse files
committed
Keep former non-normative edge case behavior.
- Leave comments about the `{"@id": null}` edge case tests but still test with current behavior. Will address the issue later.
1 parent 227fccb commit 91fe9d1

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

CHANGELOG.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,6 @@
33
### Changed
44
- Change EARL Assertor to Digital Bazaar, Inc.
55
- Update eslint dependencies.
6-
- **BREAKING**: Handle spec edge case where value for `@id` can expand into
7-
null. Behavior is changing to *not* output invalid JSON-LD and *potentially*
8-
outputing an extra blank node. The input in question is something like
9-
`{"@id":"@RESERVED", ...}` where `@RESERVED` will expand into `null`. Rather
10-
than outputing invalid `{"@id": null, ...}`, the new behavior will drop
11-
`@id`. When going to RDF this can cause slightly different output.
12-
Specifically, a `{}` value may exist and create a blank node. Please file an
13-
issue if this behavior causes issues. It is expected to be better addressed
14-
in a future spec.
15-
- Related [issue](https://github.com/w3c/json-ld-api/issues/480).
16-
- Normative [toRdf test case](https://w3c.github.io/json-ld-api/tests/toRdf-manifest.html#te122)
17-
*that now fails*.
18-
- Non-normative [expand test case](https://w3c.github.io/json-ld-api/tests/expand-manifest.html#t0122)
19-
that now fails.
206

217
### Added
228
- Support benchmarks in Karma tests.

tests/test-common.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,12 @@ const TEST_TYPES = {
6262
// NOTE: idRegex format:
6363
//MMM-manifest#tNNN$/,
6464
idRegex: [
65+
// spec issues
66+
// Unclear how to handle {"@id": null} edge case
67+
// See https://github.com/w3c/json-ld-api/issues/480
68+
// non-normative test, also see toRdf-manifest#te122
69+
///expand-manifest#t0122$/,
70+
6571
// misc
6672
/expand-manifest#tc037$/,
6773
/expand-manifest#tc038$/,
@@ -187,6 +193,12 @@ const TEST_TYPES = {
187193
// NOTE: idRegex format:
188194
//MMM-manifest#tNNN$/,
189195
idRegex: [
196+
// spec issues
197+
// Unclear how to handle {"@id": null} edge case
198+
// See https://github.com/w3c/json-ld-api/issues/480
199+
// normative test, also see expand-manifest#t0122
200+
///toRdf-manifest#te122$/,
201+
190202
// misc
191203
/toRdf-manifest#tc037$/,
192204
/toRdf-manifest#tc038$/,

0 commit comments

Comments
 (0)