forked from IGS/gEAR
-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
issue listGeneric issue/feature list by themeGeneric issue/feature list by theme
Description
Issues and features related to data upload.
- Data upload (H5AD)
[BUG] Currently, if uploading in H5AD format, the original data is left under uploads/files. We can either handle this case differently, or just remove the original data.- [FEATURE] We need to determine how best to allow using existing unstructured metadata, layers, or observation/variable-level matrices (such as UMAP, etc. )
- Data upload (large data) - [ENHANCEMENT]
For relatively large datasets (e.g. 10G H5AD file), the current upload is not suitable, this will take forever, or will be interrupted.
Meanwhile, I added a new apache2 config unlimited_uploads.conf with LimitRequestBody 0
, and further raised the PHP limits
post_max_size = 0
upload_max_filesize = 30000M
max_execution_time = 300
but there may be other timeout configurations that may also interrupt PHP execution. We need to think of a longer term solution. See #14 , I think this will work, at least for now. If we keep this solution, we should clean the PHP upload script and add proper logging.
- Data upload (general)
[QUESTION] It looks like the original metadata is left under uploads/files. This might raise security issues. Should we remove it?- [DOCUMENTATION] We need to update the documentation, in particular for H5AD (and prioritize this format, at least for scRNA-seq).
- [REMARK] File names must match exactly, otherwise upload will fail without any meaningful error message, e.g. if using gene.tab instead of genes.tab. Documentation should either be clear about this, or we allow some fuzziness in file names during upload, or we make sure an appropriate error message is displayed.
- [REMARK] For failed uploads, some files may remain under /tmp or files/uploads.
Metadata
Metadata
Assignees
Labels
issue listGeneric issue/feature list by themeGeneric issue/feature list by theme