Why doesn't Identifiable derive implement the trait for the table structs but only for references?
#4589
-
|
Hi, I just read the code defining the identifiable derive, and I noticed that the trait is not actually implemented for the struct Why is that? Wouldn't it be desirable to have it also for Do let me know, I can quickly make a PR adding it if needed. Best, |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 4 replies
-
|
See #1571 for reasons why it is that way. |
Beta Was this translation helpful? Give feedback.
-
|
Ok - I have made a macro to derive it for my projects, although I still feel it is weird to not add it here. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
It's generally really bad style to ping people like that. Don't do that in the diesel issue tracker. That written: Issues that were relevant years ago don't go away just because you ask. If you don't have a new solution to the problem described back then you are bringing anything forward by asking such questions in the first place. |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, I wasn't aware it was considered bad etiquette here. I will avoid doing that in the future. |
Beta Was this translation helpful? Give feedback.
See #1571 for reasons why it is that way.