WIP Disallow initiating webhook server without host url and port

* Cover with tests

Author: morrieinmaas

aries_cloudcontroller/aries_controller.py

@@ -37,19 +37,22 @@ def __post_init__(self):
             )
 
     def init_webhook_server(
-        self, webhook_host: str = None, webhook_port: int = None, webhook_base: str = ""
+        self, webhook_host: str, webhook_port: int, webhook_base: str = ""
     ):
         """Create a webhooklisteners
 
         Args:
         ----
         webhook_host : str
-            The url of the webhook host (default is None)
+            The url of the webhook host
         webhook_port : int
-            The exposed port for webhooks on the host (default is None)
+            The exposed port for webhooks on the host
         webhook_base : str
             The base url for webhooks (default is "")
         """
+        assert type(webhook_host) is str
+        assert webhook_host != ""
+        assert type(webhook_port) is int
         self.webhook_server: AriesWebhookServer = AriesWebhookServer(
             webhook_host=webhook_host,
             webhook_port=webhook_port,

tests/test_aries_controller.py

@@ -11,7 +11,7 @@
 class TestAriesAgentController:
 
     admin_url = "0.0.0.0"
-    webhook_host = ""
+    webhook_host = "0.0.0.0"
     webhook_port = 8000
     webhook_base = ""
 
@@ -50,6 +50,24 @@ async def test_init_webhook_server(self):
         assert ac.webhook_server.is_multitenant
         await ac.terminate()
 
+    @pytest.mark.asyncio
+    async def test_init_webhook_server_args_host_type(self):
+        with pytest.raises(AssertionError):
+            ac = AriesAgentController(admin_url=self.admin_url, is_multitenant=True)
+            ac.init_webhook_server(webhook_host=1234, webhook_port=1234, webhook_base=self.webhook_base)
+
+    @pytest.mark.asyncio
+    async def test_init_webhook_server_args_host_non_empty(self):
+        with pytest.raises(AssertionError):
+            ac = AriesAgentController(admin_url=self.admin_url, is_multitenant=True)
+            ac.init_webhook_server(webhook_host="", webhook_port=1234, webhook_base=self.webhook_base)
+
+    @pytest.mark.asyncio
+    async def test_init_webhook_server_args_port(self):
+        with pytest.raises(AssertionError):
+            ac = AriesAgentController(admin_url=self.admin_url, is_multitenant=True)
+            ac.init_webhook_server(webhook_host="", webhook_port="1234", webhook_base=self.webhook_base)
+
     @pytest.mark.asyncio
     async def test_listen_webhooks_error(self, caplog):
         caplog.set_level(logging.WARNING)