Skip to content

Commit 890f059

Browse files
committed
Tidying up and fixing logical error in token assignment in aries
controller
1 parent cf7cad5 commit 890f059

File tree

6 files changed

+264
-308
lines changed

6 files changed

+264
-308
lines changed

libs/aries-basic-controller/aries_basic_controller/aries_controller.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@ def __init__(
5959
headers = {}
6060

6161
if api_key:
62-
headers = headers.update({"X-API-Key": api_key})
62+
headers.update({"X-API-Key": api_key})
6363

6464
if tennant_jwt:
65-
headers = headers.update({'Authorization': 'Bearer ' + tennant_jwt, 'content-type': "application/json"})
65+
headers.update({'Authorization': 'Bearer ' + tennant_jwt, 'content-type': "application/json"})
6666

6767
self.client_session: ClientSession = ClientSession(headers=headers)
6868

tutorials/1. Learning Aries, ACA-Py and the Basic Controller/notebooks/alice/1 Basic Concepts and 1st Connection/Part 3 - Establishing a Connection.ipynb

Lines changed: 9 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,9 @@
4545
},
4646
{
4747
"cell_type": "code",
48-
"execution_count": 6,
48+
"execution_count": null,
4949
"metadata": {},
50-
"outputs": [
51-
{
52-
"name": "stdout",
53-
"output_type": "stream",
54-
"text": [
55-
"IPython autoawait is `on`, and set to use `asyncio`\n"
56-
]
57-
}
58-
],
50+
"outputs": [],
5951
"source": [
6052
"%autoawait\n",
6153
"import time\n",
@@ -77,7 +69,7 @@
7769
},
7870
{
7971
"cell_type": "code",
80-
"execution_count": 7,
72+
"execution_count": null,
8173
"metadata": {},
8274
"outputs": [],
8375
"source": [
@@ -112,26 +104,9 @@
112104
},
113105
{
114106
"cell_type": "code",
115-
"execution_count": 14,
107+
"execution_count": null,
116108
"metadata": {},
117-
"outputs": [
118-
{
119-
"name": "stderr",
120-
"output_type": "stream",
121-
"text": [
122-
"Task exception was never retrieved\n",
123-
"future: <Task finished name='Task-23' coro=<AriesAgentController.listen_webhooks() done, defined at /aries_basic_controller/aries_controller.py:173> exception=OSError(98, \"error while attempting to bind on address ('0.0.0.0', 8022): address already in use\")>\n",
124-
"Traceback (most recent call last):\n",
125-
" File \"/aries_basic_controller/aries_controller.py\", line 179, in listen_webhooks\n",
126-
" await self.webhook_site.start()\n",
127-
" File \"/opt/conda/lib/python3.8/site-packages/aiohttp/web_runner.py\", line 121, in start\n",
128-
" self._server = await loop.create_server(\n",
129-
" File \"/opt/conda/lib/python3.8/asyncio/base_events.py\", line 1463, in create_server\n",
130-
" raise OSError(err.errno, 'error while attempting '\n",
131-
"OSError: [Errno 98] error while attempting to bind on address ('0.0.0.0', 8022): address already in use\n"
132-
]
133-
}
134-
],
109+
"outputs": [],
135110
"source": [
136111
"\n",
137112
"loop = asyncio.get_event_loop()\n",
@@ -166,33 +141,9 @@
166141
},
167142
{
168143
"cell_type": "code",
169-
"execution_count": 13,
144+
"execution_count": null,
170145
"metadata": {},
171-
"outputs": [
172-
{
173-
"ename": "ClientResponseError",
174-
"evalue": "401, message='Unauthorized', url=URL('http://alice-agent:8021/connections/create-invitation')",
175-
"output_type": "error",
176-
"traceback": [
177-
"\u001b[0;31m---------------------------------------------------------------------------\u001b[0m",
178-
"\u001b[0;31mClientResponseError\u001b[0m Traceback (most recent call last)",
179-
"\u001b[0;32m<ipython-input-13-12511497dd12>\u001b[0m in \u001b[0;36m<module>\u001b[0;34m\u001b[0m\n\u001b[1;32m 1\u001b[0m \u001b[0;31m# Create Invitation\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[0;32m----> 2\u001b[0;31m \u001b[0minvite\u001b[0m \u001b[0;34m=\u001b[0m \u001b[0;32mawait\u001b[0m \u001b[0magent_controller\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mconnections\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mcreate_invitation\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[0m\u001b[1;32m 3\u001b[0m \u001b[0mconnection_id\u001b[0m \u001b[0;34m=\u001b[0m \u001b[0minvite\u001b[0m\u001b[0;34m[\u001b[0m\u001b[0;34m\"connection_id\"\u001b[0m\u001b[0;34m]\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[1;32m 4\u001b[0m \u001b[0minvite_message\u001b[0m \u001b[0;34m=\u001b[0m \u001b[0minvite\u001b[0m\u001b[0;34m[\u001b[0m\u001b[0;34m'invitation'\u001b[0m\u001b[0;34m]\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[1;32m 5\u001b[0m \u001b[0mprint\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0;34m\"Connection ID\"\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0mconnection_id\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n",
180-
"\u001b[0;32m/aries_basic_controller/controllers/connections.py\u001b[0m in \u001b[0;36mcreate_invitation\u001b[0;34m(self, alias, auto_accept, public, multi_use)\u001b[0m\n\u001b[1;32m 75\u001b[0m \u001b[0mparams\u001b[0m\u001b[0;34m[\u001b[0m\u001b[0;34m\"multi_use\"\u001b[0m\u001b[0;34m]\u001b[0m \u001b[0;34m=\u001b[0m \u001b[0mmulti_use\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[1;32m 76\u001b[0m \u001b[0;34m\u001b[0m\u001b[0m\n\u001b[0;32m---> 77\u001b[0;31m \u001b[0minvite_details\u001b[0m \u001b[0;34m=\u001b[0m \u001b[0;32mawait\u001b[0m \u001b[0mself\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0madmin_POST\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0;34m\"/connections/create-invitation\"\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0mparams\u001b[0m \u001b[0;34m=\u001b[0m \u001b[0mparams\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[0m\u001b[1;32m 78\u001b[0m \u001b[0mconnection\u001b[0m \u001b[0;34m=\u001b[0m \u001b[0mConnection\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0minvite_details\u001b[0m\u001b[0;34m[\u001b[0m\u001b[0;34m\"connection_id\"\u001b[0m\u001b[0;34m]\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0;34m\"invitation\"\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[1;32m 79\u001b[0m \u001b[0mself\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mconnections\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mappend\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0mconnection\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n",
181-
"\u001b[0;32m/aries_basic_controller/controllers/base.py\u001b[0m in \u001b[0;36madmin_POST\u001b[0;34m(self, path, json_data, text, params, data)\u001b[0m\n\u001b[1;32m 93\u001b[0m \u001b[0;34m(\u001b[0m\u001b[0;34m\" with data: \\n{}\"\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mformat\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0mrepr_json\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0mjson_data\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m)\u001b[0m \u001b[0;32mif\u001b[0m \u001b[0mjson_data\u001b[0m \u001b[0;32melse\u001b[0m \u001b[0;34m\"\"\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m,\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[1;32m 94\u001b[0m )\n\u001b[0;32m---> 95\u001b[0;31m \u001b[0mresponse\u001b[0m \u001b[0;34m=\u001b[0m \u001b[0;32mawait\u001b[0m \u001b[0mself\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0madmin_request\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0;34m\"POST\"\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0mpath\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0mjson_data\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0mtext\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0mparams\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0mdata\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[0m\u001b[1;32m 96\u001b[0m EVENT_LOGGER.debug(\n\u001b[1;32m 97\u001b[0m \u001b[0;34m\"Response from POST %s received: \\n%s\"\u001b[0m\u001b[0;34m,\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n",
182-
"\u001b[0;32m/aries_basic_controller/controllers/base.py\u001b[0m in \u001b[0;36madmin_request\u001b[0;34m(self, method, path, json_data, text, params, data)\u001b[0m\n\u001b[1;32m 61\u001b[0m \u001b[0mmethod\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0mself\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0madmin_url\u001b[0m \u001b[0;34m+\u001b[0m \u001b[0mpath\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0mjson\u001b[0m\u001b[0;34m=\u001b[0m\u001b[0mjson_data\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0mparams\u001b[0m\u001b[0;34m=\u001b[0m\u001b[0mparams\u001b[0m\u001b[0;34m,\u001b[0m \u001b[0mdata\u001b[0m\u001b[0;34m=\u001b[0m\u001b[0mdata\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[1;32m 62\u001b[0m ) as resp:\n\u001b[0;32m---> 63\u001b[0;31m \u001b[0mresp\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mraise_for_status\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[0m\u001b[1;32m 64\u001b[0m \u001b[0mresp_text\u001b[0m \u001b[0;34m=\u001b[0m \u001b[0;32mawait\u001b[0m \u001b[0mresp\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mtext\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[1;32m 65\u001b[0m \u001b[0;32mif\u001b[0m \u001b[0;32mnot\u001b[0m \u001b[0mresp_text\u001b[0m \u001b[0;32mand\u001b[0m \u001b[0;32mnot\u001b[0m \u001b[0mtext\u001b[0m\u001b[0;34m:\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n",
183-
"\u001b[0;32m/opt/conda/lib/python3.8/site-packages/aiohttp/client_reqrep.py\u001b[0m in \u001b[0;36mraise_for_status\u001b[0;34m(self)\u001b[0m\n\u001b[1;32m 998\u001b[0m \u001b[0;32massert\u001b[0m \u001b[0mself\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mreason\u001b[0m \u001b[0;32mis\u001b[0m \u001b[0;32mnot\u001b[0m \u001b[0;32mNone\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[1;32m 999\u001b[0m \u001b[0mself\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mrelease\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[0;32m-> 1000\u001b[0;31m raise ClientResponseError(\n\u001b[0m\u001b[1;32m 1001\u001b[0m \u001b[0mself\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mrequest_info\u001b[0m\u001b[0;34m,\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[1;32m 1002\u001b[0m \u001b[0mself\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mhistory\u001b[0m\u001b[0;34m,\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n",
184-
"\u001b[0;31mClientResponseError\u001b[0m: 401, message='Unauthorized', url=URL('http://alice-agent:8021/connections/create-invitation')"
185-
]
186-
},
187-
{
188-
"name": "stdout",
189-
"output_type": "stream",
190-
"text": [
191-
"\u001b[0m\u001b[?7h\u001b[0;34mError during POST /connections/create-invitation: 401, message='Unauthorized', url=URL('http://alice-agent:8021/connections/create-invitation')\u001b[0m\n",
192-
"\u001b[0m"
193-
]
194-
}
195-
],
146+
"outputs": [],
196147
"source": [
197148
"# Create Invitation\n",
198149
"invite = await agent_controller.connections.create_invitation()\n",
@@ -306,17 +257,9 @@
306257
},
307258
{
308259
"cell_type": "code",
309-
"execution_count": 8,
260+
"execution_count": null,
310261
"metadata": {},
311-
"outputs": [
312-
{
313-
"name": "stdout",
314-
"output_type": "stream",
315-
"text": [
316-
"None\n"
317-
]
318-
}
319-
],
262+
"outputs": [],
320263
"source": [
321264
"response = await agent_controller.terminate()\n",
322265
"print(response)"

tutorials/1. Learning Aries, ACA-Py and the Basic Controller/notebooks/bob/1 Basic Concepts and 1st Connection/Part 3 - Establishing a Connection.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
"outputs": [],
111111
"source": [
112112
"#Paste in invitation from Alice agent\n",
113-
"invitation = {'@type': 'did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/connections/1.0/invitation', '@id': '67f3c865-995e-436e-b458-ea8234c714ce', 'recipientKeys': ['9RzVRHXZoEkyz3MLQ3pn4gCM7eHi7xhm7wigbTh6SRMz'], 'label': 'Alice', 'serviceEndpoint': 'http://172.17.0.1:8020'}\n"
113+
"invitation = {'@type': 'did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/connections/1.0/invitation', '@id': 'e755dc99-9f61-4ab8-a59c-3f449a0287c3', 'label': 'Alice', 'recipientKeys': ['7rh9AtsmZg2QXVgePCUgsGUSn4VVAcxeBeadSMVmwkrb'], 'serviceEndpoint': 'http://172.17.0.1:8020'}"
114114
]
115115
},
116116
{

0 commit comments

Comments
 (0)