Merge pull request #37 from didx-xyz/feature/minor-bugs

Fix minor bugs in recovation and issuer api

Author: morrieinmaas

aries_cloudcontroller/controllers/issuer.py

@@ -26,9 +26,24 @@ def __init__(
         self.definitions = definition_controller
 
     # Fetch all credential exchange records
-    async def get_records(self):
-
-        return await self.admin_GET(f"{self.base_url}/records")
+    async def get_records(
+        self,
+        connection_id: str = None,
+        thread_id: str = None,
+        state: str = None,
+        role: str = None,
+    ):
+        params = {}
+        if connection_id:
+            params["connection_id"] = connection_id
+        if thread_id:
+            params["thread_id"] = thread_id
+        if state:
+            params["state"] = state
+        if role:
+            params["role"] = role
+
+        return await self.admin_GET(f"{self.base_url}/records", params=params)
 
     async def get_record_by_id(self, cred_ex_id):
         return await self.admin_GET(f"{self.base_url}/records/{cred_ex_id}")

aries_cloudcontroller/controllers/revocation.py

@@ -15,9 +15,9 @@ def __init__(self, admin_url: str, client_session: ClientSession):
 
     async def revoke_credential(
         self,
-        cred_ex_id: str = "",
-        cred_rev_id: str = "",
-        rev_reg_id: str = "",
+        cred_ex_id: str = None,
+        cred_rev_id: str = None,
+        rev_reg_id: str = None,
         publish: bool = False,
     ):
         """