Make credential_id optional in store_credentials fct so

morrieinmaas · morrieinmaas · commit 4d901b6cbdff · 2021-04-21T21:02:59.000+02:00
* it only gets passed when provided
* reflects the trith of the API where it is optional
diff --git a/aries_cloudcontroller/controllers/issuer.py b/aries_cloudcontroller/controllers/issuer.py
@@ -135,8 +135,10 @@ async def issue_credential(self, cred_ex_id, comment, attributes):
         )
 
     # Store a received credential
-    async def store_credential(self, cred_ex_id, credential_id):
-        body = {"credential_id": credential_id}
+    async def store_credential(self, cred_ex_id, credential_id: str = None):
+        body = {}
+        if credential_id:
+            body['credential_id'] = credential_id
         return await self.admin_POST(
             f"{self.base_url}/records/{cred_ex_id}/store", json_data=body
         )

Original file line number	Diff line number	Diff line change
`@@ -135,8 +135,10 @@ async def issue_credential(self, cred_ex_id, comment, attributes):`
`135`	`135`	`)`
`136`	`136`
`137`	`137`	`# Store a received credential`
`138`		`- async def store_credential(self, cred_ex_id, credential_id):`
`139`		`- body = {"credential_id": credential_id}`
	`138`	`+ async def store_credential(self, cred_ex_id, credential_id: str = None):`
	`139`	`+ body = {}`
	`140`	`+ if credential_id:`
	`141`	`+ body['credential_id'] = credential_id`
`140`	`142`	`return await self.admin_POST(`
`141`	`143`	`f"{self.base_url}/records/{cred_ex_id}/store", json_data=body`
`142`	`144`	`)`