DeGiro V3 feedback

[sandervankasteel]

Hi,

I've been trying our your Export-To-Ghostfolio and the DeGiro V3 importer appears to be failing over the following line;

17-01-2025,19:00,17-01-2025,,,"Overboeking naar uw geldrekening bij flatexDEGIRO Bank: 0,41 EUR",,,,EUR,30.91,

The problem appears to be fact that it breaks because there is no mutation value assigned to the row, but it's a row that's created

Example rows;

17-01-2025,19:00,17-01-2025,,,"Overboeking naar uw geldrekening bij flatexDEGIRO Bank: 0,41 EUR",,,,EUR,30.91,
17-01-2025,07:14,16-01-2025,ING GROEP NV,NL0011821202,Dividendbelasting,,EUR,-0.07,EUR,30.50,
17-01-2025,07:14,16-01-2025,ING GROEP NV,NL0011821202,Dividend,,EUR,0.48,EUR,30.57,

If there is something I can do, to help out, please let me know. I'm glad to help out with testing.

[dickwolff]

Hi,

Thanks for reporting this! When I run the tool with just those 3 lines it seems to work just fine, both V2 and V3. See the output below:

{
    "meta": {
        "date": "2025-01-28T21:13:13.206Z",
        "version": "v0"
    },
    "activities": [
        {
            "accountId": "2918fee8-180a-470c-9ac6-8138837d5fc7",
            "comment": "Dividend NL0011821202 @ 17-01-2025T07:14",
            "fee": 0.07,
            "quantity": 1,
            "type": "DIVIDEND",
            "unitPrice": 0.48,
            "currency": "EUR",
            "dataSource": "YAHOO",
            "date": "2025-01-17T07:14:00+01:00",
            "symbol": "INGA.AS"
        }
    ],
    "updateCashBalance": false
}

I just checked the code and there is a check to ignore records containing "flatex". Which version of the tool are you running?

[sandervankasteel]

I'm using the :latest tag of the docker image, which I believe is 0.26.0.

What I see in the logs are the following errors;

[e] Import failed!
[e]	activities.5.fee must not be less than 0
[e]	activities.5.fee must be a number conforming to the specified constraints

Just to make sure, that I am not confusing the records, are the headers included in the counting of the activities. index?

[dickwolff]

Yes, the specified line in the error is the line in your CSV 🙂

[sandervankasteel]

I've doing a bit more digging into this. It appears that this is the offending line.

30-12-2024,07:25,27-12-2024,ISHARES CHINA CNY BOND UCITS ETF USD,IE00BYPC1H27,Dividend,,USD,0.23,USD,0.23,

After trying to import the file in Ghostfolio, it appears that the fee gets cast to a null instead of 0.

That record gets parsed into the following JSON object.

{
  "accountId": "ba3638ca-1a1d-4ef1-8a02-f17601ac4009",
  "comment": "Dividend IE00BYPC1H27 @ 30-12-2024T07:25",
  "fee": null,
  "quantity": 1,
  "type": "DIVIDEND",
  "unitPrice": 0.23,
  "currency": "USD",
  "dataSource": "YAHOO",
  "date": "2024-12-30T07:25:00+00:00",
  "symbol": "CNYB.SW"
}

Screenshot:

[sandervankasteel]

After doing a little more digging, it appears to be matching the next record in the CSV, which appears to be "flatexDEGIRO" transfer record.

30-12-2024,07:25,27-12-2024,ISHARES CHINA CNY BOND UCITS ETF USD,IE00BYPC1H27,Dividend,,USD,0.23,USD,0.23,
18-12-2024,18:15,18-12-2024,,,"Overboeking naar uw geldrekening bij flatexDEGIRO Bank: 0,4 EUR",,,,EUR,26.39,

It look likes it matches positively in the findMatchByOrderId() function because in both rows, the "order_id" column is an empty string, which matches.