Skip to content

Using two bubble styles for two characters will make sound lost. #2628

@jinyangcruise

Description

@jinyangcruise

The problem

Describe the bug
When using two bubble styles for two characters and assigning sounds to them, sound can not be applied to the DialogicNode_TypeSounds correctly.

To Reproduce

Make two bubble styles and assign each to one character. Assign some sounds to one of the characters.
Make some simple timeline. At the beginning, the sound is correct, but after some dialogs, the sound will be missing.

Image Image

Expected behavior
Sound should not be missing.

System (please complete the following information):

  • OS: Windows 11
  • Godot Version: v4.5.beta3.official
  • Dialogic Version: 2.0 Alpha 17

Solutions

The reason for this issue is: when a character says something, the system will first update its mood(the DialogicNode_TypeSounds of current layout will be set some sounds information), then update its style.
But when updating its style, if the character has a different style, the previous style will be removed thus the sound information will be gone, and the newly created layout does not know that the previously set sounds are not yet used.

I will do a PR for this.

Image Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bug 🐞Something isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions