Skip to content

Commit d39b3f9

Browse files
authored
fix: diff report more object members in actual (#74)
1 parent f5d0bd1 commit d39b3f9

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

src/main/java/org/hisp/dhis/jsontree/JsonDiff.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ private static void diffNumber(JsonNumber e, JsonNumber a, Mode mode, Consumer<D
197197

198198
private static void diffObject(
199199
JsonObject e, JsonObject a, Mode mode, Consumer<Difference> add, PropertyInfo p) {
200-
if (!p.anyAdditional(mode.objects.anyAdditional) && e.size() != a.size()) {
200+
if (!p.anyAdditional(mode.objects.anyAdditional)) {
201201
// list all extra members
202202
a.keys()
203203
.filter(not(e::has))

src/test/java/org/hisp/dhis/jsontree/JsonDiffTest.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,18 @@ void testObject() {
7777
assertDiff("{\"a\":[1,2,3]}", "{\"a\":[1,5,3]}", "!= $.a[1]: 2 <> 5");
7878
}
7979

80+
@Test
81+
void testObject_Pager() {
82+
assertDiff(
83+
"""
84+
{"page":1, "pageSize":50}""",
85+
"""
86+
{"paga":1, "pageSize":50.0}""",
87+
DEFAULT,
88+
"++ $.paga: ? <> 1",
89+
"-- $.page: 1 <> ?");
90+
}
91+
8092
private interface JsonAnyAnnotationObject extends JsonObject {
8193

8294
@JsonDiff.AnyOrder

0 commit comments

Comments
 (0)