Skip to content

Document the significance of Nothing :: Maybe CharacterSet #2527

Open
@fpringle

Description

@fpringle

The Lam, Pi, Combine, CombineTypes, Prefer and Equivalent constructors of Expr all have a Maybe CharacterSet field, without any documentation describing what a Nothing would signify in this context. Based on the source code I believe Nothing means "infer the CharacterSet based on the input". If this it the case, some documentation should be added to the constructors to explain this. Alternatively, a sum-type would be more expressive e.g.

data CharacterSetSource
  = Infer
  | Specify CharacterSet

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions