Skip to content

Commit a0afb22

Browse files
committed
[IDX-2606] Build a separte dev guest-os image with fixed ic version.
1 parent 99b0b96 commit a0afb22

File tree

3 files changed

+57
-43
lines changed

3 files changed

+57
-43
lines changed

ic-os/defs.bzl

Lines changed: 41 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -399,58 +399,61 @@ def icos_build(name, upload_prefix, image_deps, mode = None, malicious = False,
399399
if malicious:
400400
upload_suffix += "-malicious"
401401

402-
upload_artifacts(
403-
name = "upload_disk-img",
404-
inputs = [
405-
":disk-img.tar.zst",
406-
":disk-img.tar.gz",
407-
],
408-
remote_subdir = upload_prefix + "/disk-img" + upload_suffix,
409-
)
410-
411-
output_files(
412-
name = "disk-img-url",
413-
target = ":upload_disk-img",
414-
basenames = ["upload_disk-img_disk-img.tar.zst.url"],
415-
visibility = ["//visibility:public"],
416-
tags = ["manual"],
417-
)
418-
419-
if upgrades:
402+
if upload_prefix != None:
420403
upload_artifacts(
421-
name = "upload_update-img",
404+
name = "upload_disk-img",
422405
inputs = [
423-
":update-img.tar.zst",
424-
":update-img.tar.gz",
425-
":update-img-test.tar.zst",
426-
":update-img-test.tar.gz",
406+
":disk-img.tar.zst",
407+
":disk-img.tar.gz",
427408
],
428-
remote_subdir = upload_prefix + "/update-img" + upload_suffix,
409+
remote_subdir = upload_prefix + "/disk-img" + upload_suffix,
410+
)
411+
412+
output_files(
413+
name = "disk-img-url",
414+
target = ":upload_disk-img",
415+
basenames = ["upload_disk-img_disk-img.tar.zst.url"],
416+
visibility = ["//visibility:public"],
417+
tags = ["manual"],
429418
)
430419

431-
# -------------------- Bazel ergonomics --------------------
420+
if upgrades:
421+
upload_artifacts(
422+
name = "upload_update-img",
423+
inputs = [
424+
":update-img.tar.zst",
425+
":update-img.tar.gz",
426+
":update-img-test.tar.zst",
427+
":update-img-test.tar.gz",
428+
],
429+
remote_subdir = upload_prefix + "/update-img" + upload_suffix,
430+
)
432431

433-
native.filegroup(
434-
name = "hash_and_upload_disk-img",
435-
srcs = [
436-
":upload_disk-img",
437-
":disk-img.tar.zst.sha256",
438-
],
439-
visibility = ["//visibility:public"],
440-
tags = ["manual"],
441-
)
432+
# -------------------- Bazel ergonomics --------------------
442433

443-
if upgrades:
444434
native.filegroup(
445-
name = "hash_and_upload_update-img",
435+
name = "hash_and_upload_disk-img",
446436
srcs = [
447-
":upload_update-img",
448-
":update-img.tar.zst.sha256",
437+
":upload_disk-img",
438+
":disk-img.tar.zst.sha256",
449439
],
450440
visibility = ["//visibility:public"],
451441
tags = ["manual"],
452442
)
453443

444+
if upgrades:
445+
native.filegroup(
446+
name = "hash_and_upload_update-img",
447+
srcs = [
448+
":upload_update-img",
449+
":update-img.tar.zst.sha256",
450+
],
451+
visibility = ["//visibility:public"],
452+
tags = ["manual"],
453+
)
454+
455+
# end if upload_prefix != None
456+
454457
if upgrades:
455458
upgrade_outputs = [
456459
":update-img.tar.zst",
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
load("//ic-os:defs.bzl", "icos_build")
2+
load("//ic-os/guestos:defs.bzl", "image_deps")
3+
4+
# The macro contains several targets.
5+
# Check
6+
# //ic-os/guestos/BUILD.bazel for examples
7+
# or //ic-os/defs.bzl for the full list of targets.
8+
icos_build(
9+
name = "dev",
10+
ic_version = "//bazel:rc_only_version.txt",
11+
image_deps = image_deps,
12+
upload_prefix = None,
13+
visibility = ["//visibility:public"],
14+
)

publish/binaries/BUILD.bazel

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,7 @@ BINARIES = {
6464
name = name,
6565
binary = BINARIES[name],
6666
visibility = [
67-
"//ic-os/guestos/envs/dev:__pkg__",
68-
"//ic-os/guestos/envs/dev-malicious:__pkg__",
69-
"//ic-os/guestos/envs/prod:__pkg__",
67+
"//ic-os/guestos/envs:__subpackages__",
7068
"//ic-os/hostos/envs/dev:__pkg__",
7169
"//ic-os/hostos/envs/prod:__pkg__",
7270
],
@@ -82,8 +80,7 @@ BINARIES = {
8280
"//ic-os/boundary-guestos/envs/dev-sev:__pkg__",
8381
"//ic-os/boundary-guestos/envs/prod:__pkg__",
8482
"//ic-os/boundary-guestos/envs/prod-sev:__pkg__",
85-
"//ic-os/guestos/envs/dev:__pkg__",
86-
"//ic-os/guestos/envs/dev-malicious:__pkg__",
83+
"//ic-os/guestos/envs:__subpackages__",
8784
"//ic-os/guestos/envs/prod:__pkg__",
8885
"//ic-os/hostos/envs/dev:__pkg__",
8986
"//ic-os/hostos/envs/prod:__pkg__",

0 commit comments

Comments
 (0)