Merge branch 'levsha/-IDX-2606-Pass-params-as-named-env-variables-instead-of-command-line-args-' into 'master'

[IDX-2606] Pass params as named env variables instead of command line args.

This makes the code more self-explanatory and protects against mistakes
in the future when adding/removing params could cause using wrong param. 

See merge request dfinity-lab/public/ic!12604

Author: levsha

scalability/BUILD.bazel

@@ -272,15 +272,15 @@ sh_test(
     name = "run-e2e-scalability-tests",
     timeout = "long",
     srcs = ["common/tests/e2e-scalability-tests.sh"],
-    args = [
-        "$(rootpath :e2e-scalability-tests)",
-        "$(rootpath //ic-os/guestos/envs/dev:version.txt)",
-    ],
     data = [
         ":e2e-scalability-tests",
         "//ic-os:scripts/build-bootstrap-config-image.sh",
         "//ic-os/guestos/envs/dev:version.txt",
     ],
+    env = {
+        "E2E_TEST_BIN": "$(rootpath :e2e-scalability-tests)",
+        "IC_OS_VERSION_FILE": "$(rootpath //ic-os/guestos/envs/dev:version.txt)",
+    },
     env_inherit = [
         "CI_PROJECT_DIR",
         "HOME",

scalability/common/tests/e2e-scalability-tests.sh

@@ -15,7 +15,8 @@ if [ -f "${STATUSFILE}" ]; then
     done <"$STATUSFILE"
 fi
 
-exec $1 --ic_os_version $(cat $2) \
+exec "${E2E_TEST_BIN}" \
+    --ic_os_version "$(cat "${IC_OS_VERSION_FILE}")" \
     --artifacts_path "scalability/artifacts/release/" \
     --nns_canisters "scalability/artifacts/canisters/" \
     --install_nns_bin "scalability/artifacts/release/ic-nns-init" \