fix: convert getPluginsDetail params to plural names

Author: AbhishekA1509

src/Shared/Components/Plugin/PluginList.tsx

@@ -4,13 +4,7 @@ import PluginCard from './PluginCard'
 import { DetectBottom } from '../DetectBottom'
 import PluginCardSkeletonList from './PluginCardSkeletonList'
 import { PluginListParamsType, PluginListProps } from './types'
-import {
-    abortPreviousRequests,
-    GenericEmptyState,
-    GenericFilterEmptyState,
-    getIsRequestAborted,
-    showError,
-} from '../../../Common'
+import { abortPreviousRequests, GenericEmptyState, GenericFilterEmptyState, ImageType } from '../../../Common'
 import { getPluginStoreData } from './service'
 
 const PluginList = ({
@@ -46,17 +40,15 @@ const PluginList = ({
 
             handleDataUpdateForPluginResponse(pluginDataResponse, true)
         } catch (error) {
-            if (!getIsRequestAborted(error)) {
-                showError(error)
-            }
+            // Do nothing
         } finally {
             setIsLoadingMorePlugins(false)
         }
     }
 
     if (!pluginList.length) {
         if (!!searchKey || !!selectedTags.length) {
-            return <GenericFilterEmptyState handleClearFilters={handleClearFilters} />
+            return <GenericFilterEmptyState handleClearFilters={handleClearFilters} imageType={ImageType.Large} />
         }
 
         // Not going to happen but still handling in case of any issue that might arise

src/Shared/Components/Plugin/service.tsx

@@ -14,14 +14,14 @@ import { parsePluginDetailsDTOIntoPluginStore } from './utils'
 
 export const getPluginsDetail = async ({
     appId,
-    parentPluginId,
-    pluginId,
+    parentPluginIds,
+    pluginIds,
 }: PluginDetailServiceParamsType): Promise<Pick<GetPluginStoreDataReturnType, 'pluginStore'>> => {
     try {
         const payload: PluginDetailPayloadType = {
             appId,
-            parentPluginId,
-            pluginId,
+            parentPluginId: parentPluginIds,
+            pluginId: pluginIds,
         }
 
         const { result } = (await get(
@@ -60,7 +60,7 @@ export const getPluginStoreData = async ({
 
         const pluginStore = parsePluginDetailsDTOIntoPluginStore(result?.parentPlugins)
         return {
-            totalCount: result.totalCount,
+            totalCount: result?.totalCount || 0,
             pluginStore,
         }
     } catch (error) {

src/Shared/Components/Plugin/types.ts

@@ -60,11 +60,14 @@ export interface PluginDetailDTO {
 
 export interface PluginDetailServiceParamsType {
     appId: number
-    pluginId?: number[]
-    parentPluginId?: number[]
+    pluginIds?: number[]
+    parentPluginIds?: number[]
 }
 
-export interface PluginDetailPayloadType extends PluginDetailServiceParamsType {}
+export interface PluginDetailPayloadType extends Pick<PluginDetailServiceParamsType, 'appId'> {
+    pluginId?: PluginDetailServiceParamsType['pluginIds']
+    parentPluginId?: PluginDetailServiceParamsType['parentPluginIds']
+}
 
 export interface PluginListFiltersType extends Pick<BaseFilterQueryParams<unknown>, 'searchKey'> {
     selectedTags: string[]