Skip to content

Commit fb7e30b

Browse files
committed
feat: Update AppStatusModal to conditionally show timeline based on deployment app type and remove outdated comment in processDeploymentStatusDetailsData
1 parent 37674f8 commit fb7e30b

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/Shared/Components/AppStatusModal/AppStatusModal.component.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,9 @@ const AppStatusModal = ({
7979
? appDetails.installedAppId
8080
: appDetails.appId,
8181
envId: appDetails.environmentId,
82-
showTimeline: selectedTab === AppStatusModalTabType.DEPLOYMENT_STATUS,
82+
showTimeline:
83+
selectedTab === AppStatusModalTabType.DEPLOYMENT_STATUS &&
84+
appDetails.deploymentAppType !== DeploymentAppTypes.HELM,
8385
virtualEnvironmentConfig: appDetails.isVirtualEnvironment
8486
? {
8587
processVirtualEnvironmentDeploymentData,

src/Shared/Components/DeploymentStatusBreakdown/utils.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ export const processDeploymentStatusDetailsData = (
244244

245245
// After initial processing will mark all unavailable timelines [present before last invalid state] as success
246246
PHYSICAL_ENV_DEPLOYMENT_TIMELINE_ORDER.forEach((timelineStatusType, index) => {
247-
// TODO: Confirm for findRight approach is fine? since, for e.g, i believe apply start should be before apply synced
248247
const element = findRight(data.timelines, getPredicate(timelineStatusType))
249248
const timelineData = deploymentData.deploymentStatusBreakdown[timelineStatusType]
250249

0 commit comments

Comments
 (0)