feat: add type to scan result api params

Author: arunjaindev

src/Shared/Components/Security/SecurityModal/index.ts

@@ -9,7 +9,6 @@ export {
     parseGetResourceScanDetailsResponse,
 } from './utils'
 export type {
-    AppDetailsPayload,
     ScanResultDTO,
     SidebarPropsType,
     SidebarDataChildType,

src/Shared/Components/Security/SecurityModal/service.ts

@@ -2,22 +2,23 @@ import { ROUTES } from '@Common/Constants'
 import { getUrlWithSearchParams } from '@Common/Helper'
 import { get } from '@Common/Api'
 import { ResponseType } from '@Common/Types'
-import { ScanResultDTO, AppDetailsPayload } from './types'
+import { ScanResultDTO, ScanResultParamsType } from './types'
 
 export const getSecurityScan = async ({
     appId,
     envId,
     installedAppId,
     artifactId,
     installedAppVersionHistoryId,
-}: AppDetailsPayload): Promise<ResponseType<ScanResultDTO>> => {
-    const url = getUrlWithSearchParams(ROUTES.SCAN_RESULT, {
+}: ScanResultParamsType): Promise<ResponseType<ScanResultDTO>> => {
+    const params: ScanResultParamsType = {
         appId,
         envId,
         installedAppId,
         artifactId,
         installedAppVersionHistoryId,
-    })
+    }
+    const url = getUrlWithSearchParams(ROUTES.SCAN_RESULT, params)
     const response = await get<ScanResultDTO>(url)
     return response
 }

src/Shared/Components/Security/SecurityModal/types.ts

@@ -21,7 +21,7 @@ export interface GetResourceScanDetailsPayloadType {
     isAppDetailView?: boolean
 }
 
-export interface AppDetailsPayload {
+export interface ScanResultParamsType {
     appId?: number | string
     envId?: number | string
     installedAppId?: number | string

src/Shared/Components/Security/SecurityModal/utils.tsx

@@ -63,11 +63,13 @@ export const getSecurityScanSeveritiesCount = (data: ScanResultDTO) => {
     const imageScanSeverities = data[CATEGORIES.IMAGE_SCAN].vulnerability?.summary?.severities
     const codeScanSeverities = data[CATEGORIES.CODE_SCAN].vulnerability?.summary?.severities
     return {
-        critical: (imageScanSeverities?.critical || 0) + (codeScanSeverities?.critical || 0),
-        high: (imageScanSeverities?.high || 0) + (codeScanSeverities?.high || 0),
-        medium: (imageScanSeverities?.medium || 0) + (codeScanSeverities?.medium || 0),
-        low: (imageScanSeverities?.low || 0) + (codeScanSeverities?.low || 0),
-        unknown: (imageScanSeverities?.unknown || 0) + (codeScanSeverities?.unknown || 0),
+        critical:
+            (imageScanSeverities?.[SeveritiesDTO.CRITICAL] || 0) + (codeScanSeverities?.[SeveritiesDTO.CRITICAL] || 0),
+        high: (imageScanSeverities?.[SeveritiesDTO.HIGH] || 0) + (codeScanSeverities?.[SeveritiesDTO.HIGH] || 0),
+        medium: (imageScanSeverities?.[SeveritiesDTO.MEDIUM] || 0) + (codeScanSeverities?.[SeveritiesDTO.MEDIUM] || 0),
+        low: (imageScanSeverities?.[SeveritiesDTO.LOW] || 0) + (codeScanSeverities?.[SeveritiesDTO.LOW] || 0),
+        unknown:
+            (imageScanSeverities?.[SeveritiesDTO.UNKNOWN] || 0) + (codeScanSeverities?.[SeveritiesDTO.UNKNOWN] || 0),
     }
 }
 

src/Shared/Components/Security/utils.tsx

@@ -14,11 +14,11 @@ export const getTotalSeverityCount = (severityCount: SeverityCount): number => {
 export const getSeverityCountFromSummary = (
     scanResultSeverities: Partial<Record<SeveritiesDTO, number>>,
 ): SeverityCount => ({
-    critical: scanResultSeverities?.critical || 0,
-    high: scanResultSeverities?.high || 0,
-    medium: scanResultSeverities?.medium || 0,
-    low: scanResultSeverities?.low || 0,
-    unknown: scanResultSeverities?.unknown || 0,
+    critical: scanResultSeverities?.[SeveritiesDTO.CRITICAL] || 0,
+    high: scanResultSeverities?.[SeveritiesDTO.HIGH] || 0,
+    medium: scanResultSeverities?.[SeveritiesDTO.MEDIUM] || 0,
+    low: scanResultSeverities?.[SeveritiesDTO.LOW] || 0,
+    unknown: scanResultSeverities?.[SeveritiesDTO.UNKNOWN] || 0,
 })
 
 export const getCVEUrlFromCVEName = (cveName: string): string =>