Skip to content

Commit f8de4f6

Browse files
committed
feat: add null check for execution details api result
1 parent f70c4d8 commit f8de4f6

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

src/Shared/Components/ImageCardAccordion/types.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,9 @@ export interface ImageCardAccordionProps extends MaterialSecurityInfoType {
2828
isScanned: boolean
2929
isScanEnabled: boolean
3030
SecurityModalSidebar: React.FC<SidebarPropsType>
31-
getSecurityScan: ({
32-
appId,
33-
envId,
34-
artifactId,
35-
}: Pick<AppDetailsPayload, 'appId' | 'envId' | 'artifactId'>) => Promise<ResponseType<ApiResponseResultType>>
31+
getSecurityScan: (
32+
props: Pick<AppDetailsPayload, 'appId' | 'envId' | 'artifactId'>,
33+
) => Promise<ResponseType<ApiResponseResultType>>
3634
}
3735

3836
export interface SecurityDetailsType {

src/Shared/Components/Security/SecurityModal/service.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ export const getExecutionDetails = async (
1515
const url = getUrlWithSearchParams(ROUTES.SECURITY_SCAN_EXECUTION_DETAILS, executionDetailPayload)
1616
const response = await get(url)
1717
const parsedResult = {
18-
...response.result,
19-
scanExecutionId: response.result.ScanExecutionId,
20-
lastExecution: response.result.executionTime,
21-
objectType: response.result.objectType,
18+
...(response.result || {}),
19+
scanExecutionId: response.result?.ScanExecutionId,
20+
lastExecution: response.result?.executionTime,
21+
objectType: response.result?.objectType,
2222
vulnerabilities:
2323
response.result?.vulnerabilities?.map((cve) => ({
2424
name: cve.cveName,

0 commit comments

Comments
 (0)