Merge branch 'feat/template-create' of github.com:devtron-labs/devtron-fe-common-lib into feat/template-detail

Author: Elessar1802

src/Common/Constants.ts

@@ -86,6 +86,7 @@ export const URLS = {
     GLOBAL_CONFIG: '/global-config',
     GLOBAL_CONFIG_TEMPLATES_DEVTRON_APP,
     GLOBAL_CONFIG_TEMPLATES_DEVTRON_APP_CREATE: `${GLOBAL_CONFIG_TEMPLATES_DEVTRON_APP}/create`,
+    // NOTE: using appId since we are re-using AppConfig component
     GLOBAL_CONFIG_TEMPLATES_DEVTRON_APP_DETAIL: `${GLOBAL_CONFIG_TEMPLATES_DEVTRON_APP}/detail/:appId`,
 }
 

src/Shared/Components/GenericInfoCard/styles.scss

@@ -14,7 +14,7 @@
     &:hover {
         position: relative;
         z-index: 1;
-        box-shadow: 0px 2px 8px 0px rgba(0, 0, 0, 0.10);
+        box-shadow: var(--shadow-card-secondary);
 
         // NOTE: &__title was not working here
         .generic-info-card__title {

src/Shared/Components/GenericInfoCard/types.ts

@@ -25,7 +25,7 @@ export enum GenericInfoCardBorderVariant {
 export type GenericInfoCardProps = { borderVariant: GenericInfoCardBorderVariant } & (
     | ({
           isLoading: true
-      } & Partial<BaseGenericInfoCardProps>)
+      } & Partial<Record<keyof BaseGenericInfoCardProps, never>>)
     | ({
           isLoading?: boolean
       } & BaseGenericInfoCardProps)