Skip to content

Commit eed26bd

Browse files
committed
refactor: update tooltip card styles for improved design consistency; change background to overlay and add border for better visibility
1 parent 1b6194c commit eed26bd

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

src/Shared/Components/CICDHistory/BuildAndTaskSummaryTooltipCard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const BuildAndTaskSummaryTooltipCard = memo(
2323
const executionInfo = sanitizeWorkflowExecutionStages(workflowExecutionStages)
2424

2525
return (
26-
<div className="shadow__overlay p-16 br-4 w-350 bg__primary mxh-300 dc__overflow-auto flexbox-col dc__gap-16">
26+
<div className="shadow__overlay p-16 br-4 w-350 bg__overlay border__primary mxh-300 dc__overflow-auto flexbox-col dc__gap-16">
2727
{/* Info section */}
2828
<div className="dc__icon-text-layout">
2929
<ICCalendar className={`scn-7 ${BASE_ICON_CLASS}`} />

src/Shared/Components/CICDHistory/Sidebar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const DeploymentSummaryTooltipCard = memo(
4848
ciMaterials,
4949
gitTriggers,
5050
}: DeploymentSummaryTooltipCardType): JSX.Element => (
51-
<div className="shadow__overlay p-16 br-4 w-400 bg__primary mxh-300 dc__overflow-auto">
51+
<div className="shadow__overlay p-16 br-4 w-400 bg__overlay border__primary mxh-300 dc__overflow-auto">
5252
<span className="fw-6 fs-16 mb-4" style={{ color: colorMap[status.toLowerCase()] }}>
5353
{getWorkflowNodeStatusTitle(status)}
5454
</span>

src/Shared/Components/CICDHistory/utils.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,6 @@ export const getIconFromWorkflowStageStatusType = (
297297
case WorkflowStageStatusType.SUCCEEDED:
298298
return renderSuccessTriggerIcon(baseClass)
299299

300-
// NOT_STARTED case is not expected
301300
case WorkflowStageStatusType.NOT_STARTED:
302301
case WorkflowStageStatusType.RUNNING:
303302
return renderProgressingTriggerIcon(baseClass)
@@ -321,11 +320,14 @@ export const getHistoryItemStatusIconFromWorkflowStages = (
321320
return renderProgressingTriggerIcon(baseClass)
322321
}
323322

324-
if (FAILED_WORKFLOW_STAGE_STATUS_MAP[executionInfo.workerDetails?.status]) {
323+
if (
324+
!FAILED_WORKFLOW_STAGE_STATUS_MAP[executionInfo.currentStatus] &&
325+
FAILED_WORKFLOW_STAGE_STATUS_MAP[executionInfo.workerDetails.status]
326+
) {
325327
return <ICWarningY5 className={baseClass} />
326328
}
327329

328-
return getIconFromWorkflowStageStatusType(executionInfo.currentStatus, baseClass)
330+
return getIconFromWorkflowStageStatusType(executionInfo.workerDetails.status, baseClass)
329331
}
330332

331333
export const getWorkerPodBaseUrl = (clusterId: number = DEFAULT_CLUSTER_ID, podNamespace: string = DEFAULT_NAMESPACE) =>

0 commit comments

Comments
 (0)