Skip to content

Commit e3583f6

Browse files
committed
fix: header undefined issue in artifact info modal
1 parent 6b0a741 commit e3583f6

File tree

3 files changed

+25
-23
lines changed

3 files changed

+25
-23
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "0.0.95-beta-3",
3+
"version": "0.0.95-beta-7",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Shared/Components/ArtifactInfoModal/ArtifactInfoModal.component.tsx

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -51,26 +51,28 @@ const ArtifactInfoModal = ({
5151
<div data-testid="visible-modal-commit-info" className="flexbox-col h-100">
5252
<div className="flex dc__content-space py-10 px-20 cn-9 bcn-0 dc__border-bottom">
5353
<div className="flexbox-col dc__content-center">
54-
{isInfoLoading ? (
55-
<>
56-
<div className="shimmer h-24 mb-2 w-200" />
57-
<div className="shimmer h-18 w-250" />
58-
</>
59-
) : (
60-
<>
61-
<h1 className="fs-16 fw-6 lh-24 m-0 dc__truncate">
62-
{showDescription
63-
? artifactInfo?.appName
64-
: `Source & image details of ${artifactInfo?.appName}`}
65-
</h1>
66-
{showDescription && (
67-
<p className="fs-13 cn-7 lh-1-5 m-0 dc__truncate">
68-
Deployed on {artifactInfo.environmentName} at {artifactInfo.lastDeployedTime}
69-
&nbsp;by {artifactInfo.triggeredByEmail}
70-
</p>
71-
)}
72-
</>
73-
)}
54+
{!infoError &&
55+
(isInfoLoading ? (
56+
<>
57+
<div className="shimmer h-24 mb-2 w-200" />
58+
<div className="shimmer h-18 w-250" />
59+
</>
60+
) : (
61+
<>
62+
<h1 className="fs-16 fw-6 lh-24 m-0 dc__truncate">
63+
{showDescription
64+
? artifactInfo?.appName
65+
: `Source & image details of ${artifactInfo?.appName}`}
66+
</h1>
67+
{showDescription && (
68+
<p className="fs-13 cn-7 lh-1-5 m-0 dc__truncate">
69+
Deployed on {artifactInfo.environmentName} at{' '}
70+
{artifactInfo.lastDeployedTime}
71+
&nbsp;by {artifactInfo.triggeredByEmail}
72+
</p>
73+
)}
74+
</>
75+
))}
7476
</div>
7577
<button
7678
data-testid="visible-modal-close"

0 commit comments

Comments
 (0)