Skip to content

Commit ded6700

Browse files
committed
fix: border for key value tab in case of global config
1 parent da58d52 commit ded6700

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

src/Shared/Components/KeyValueTable/KeyValueTable.component.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
import React, { createRef, useEffect, useRef, useState } from 'react'
1919

20-
import { ReactComponent as ICArrowDown } from '../../../Assets/Icon/ic-arrow-down.svg'
20+
import { ReactComponent as ICArrowDown } from '../../../Assets/Icon/ic-sort-arrow-down.svg'
2121
import { ReactComponent as ICCross } from '../../../Assets/Icon/ic-cross.svg'
2222
import { ResizableTagTextArea, SortingOrder, useStateFilters } from '../../../Common'
2323
import { DEFAULT_SECRET_PLACEHOLDER } from '../../constants'
@@ -166,7 +166,7 @@ export const KeyValueTable = <K extends string>({
166166
}
167167

168168
return (
169-
<div className="dc__border br-4 w-100 bcn-0">
169+
<div className="dc__border br-4 w-100 bcn-0 key-value">
170170
<div
171171
className={`key-value__row flexbox dc__align-items-center bcn-50 ${!isAdditionNotAllowed || updatedRows.length ? 'dc__border-bottom-n1' : ''}`}
172172
>
@@ -208,7 +208,7 @@ export const KeyValueTable = <K extends string>({
208208
>
209209
<textarea
210210
ref={key === firstHeaderKey ? inputRowRef : undefined}
211-
className="key-value__row-input key-value__row-input--add placeholder-cn5 p-0 lh-20 fs-13 fw-4"
211+
className="key-value__row-input key-value__row-input--add placeholder-cn5 p-0 lh-20 fs-13 fw-4 dc__no-border-imp dc__no-border-radius"
212212
value=""
213213
rows={1}
214214
placeholder={placeholder[key]}
@@ -234,7 +234,7 @@ export const KeyValueTable = <K extends string>({
234234
<>
235235
<ResizableTagTextArea
236236
{...row.data[key]}
237-
className="key-value__row-input placeholder-cn5 py-8 px-0"
237+
className="key-value__row-input placeholder-cn5 py-8 px-0 dc__no-border-imp dc__no-border-radius"
238238
minHeight={20}
239239
maxHeight={160}
240240
value={row.data[key].value}
@@ -254,15 +254,15 @@ export const KeyValueTable = <K extends string>({
254254
disableOnBlurResizeToMinHeight
255255
/>
256256
{row.data[key].required && (
257-
<span className="cr-5 fs-16 dc__align-self-start px-6">*</span>
257+
<span className="cr-5 fs-16 dc__align-self-start px-6 py-8">*</span>
258258
)}
259259
</>
260260
)}
261261
</div>
262262
))}
263263
<button
264264
type="button"
265-
className="dc__unset-button-styles dc__align-self-stretch dc__no-shrink flex py-10 px-8 dc__border-left-n1--important"
265+
className="dc__unset-button-styles dc__align-self-stretch dc__no-shrink flex py-10 px-8 dc__border-left-n1--important dc__hover-n50"
266266
onClick={onRowDelete(row)}
267267
>
268268
<ICCross aria-label="delete-row" className="icon-dim-16 fcn-4 dc__align-self-start cursor" />

src/Shared/Components/KeyValueTable/KeyValueTable.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@
4343
border: none;
4444
width: 100%;
4545
background: inherit;
46-
46+
4747
&--add {
4848
resize: none;
4949
border-radius: 4px;
5050
outline: none;
5151
}
5252
}
53-
}
53+
}

src/Shared/constants.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -403,3 +403,5 @@ export const APP_STATUS_HEADERS = ['KIND', 'NAME', 'STATUS', 'MESSAGE']
403403

404404
export const MATERIAL_EXCLUDE_TIPPY_TEXT =
405405
'Not available for build as this commit contains changes in excluded files or folders'
406+
407+
export const DEFAULT_SECRET_PLACEHOLDER = '••••••••'

0 commit comments

Comments
 (0)