feat: add param required in yaml validator util

Author: arunjaindev

src/Pages/GlobalConfigurations/DeploymentCharts/types.ts

@@ -25,7 +25,7 @@ interface DeploymentChartInfo {
 
 export type DeploymentChartListDTO = DeploymentChartInfo[]
 
-interface DeploymentChartVersionsType
+export interface DeploymentChartVersionsType
     extends Pick<DeploymentChartInfo, 'id' | 'version' | 'uploadedBy' | 'isUserUploaded'> {
     description: string
 }

src/Pages/GlobalConfigurations/DeploymentCharts/utils.ts

@@ -15,7 +15,12 @@
  */
 
 import { versionComparatorBySortOrder } from '@Shared/Helpers'
-import { DeploymentChartListDTO, DeploymentChartType, DEVTRON_DEPLOYMENT_CHART_NAMES } from './types'
+import {
+    DeploymentChartListDTO,
+    DeploymentChartType,
+    DeploymentChartVersionsType,
+    DEVTRON_DEPLOYMENT_CHART_NAMES,
+} from './types'
 import fallbackGuiSchema from './basicViewSchema.json'
 
 export const convertDeploymentChartListToChartType = (data: DeploymentChartListDTO): DeploymentChartType[] => {
@@ -27,27 +32,20 @@ export const convertDeploymentChartListToChartType = (data: DeploymentChartListD
             if (!name || !id || !version) {
                 return acc
             }
+            const currVersionDetail: DeploymentChartVersionsType = {
+                id,
+                version,
+                description: chartDescription || '',
+                uploadedBy: isUserUploaded ? uploadedBy || '' : 'Devtron',
+                isUserUploaded: isUserUploaded || true,
+            }
             const detail = acc[name]
             if (detail) {
-                detail.versions.push({
-                    id,
-                    version,
-                    description: chartDescription || '',
-                    uploadedBy: isUserUploaded ? uploadedBy || '' : 'Devtron',
-                    isUserUploaded,
-                })
+                detail.versions.push(currVersionDetail)
             } else {
                 acc[name] = {
                     name,
-                    versions: [
-                        {
-                            id,
-                            version,
-                            description: chartDescription || '',
-                            uploadedBy: isUserUploaded ? uploadedBy || '' : 'Devtron',
-                            isUserUploaded: isUserUploaded || true,
-                        },
-                    ],
+                    versions: [currVersionDetail],
                 }
             }
             return acc

src/Shared/validations.tsx

@@ -472,11 +472,15 @@ export const validateCMVolumeMountPath = (value: string): { isValid: boolean; me
     return { isValid: true, message: '' }
 }
 
-export const validateYAML = (yamlString: string): ValidationResponseType => {
+export const validateYAML = (yamlString: string, isRequired?: boolean): ValidationResponseType => {
     try {
-        if (yamlString) {
-            parse(yamlString)
+        if (!yamlString && isRequired) {
+            return {
+                isValid: false,
+                message: 'Empty yaml string',
+            }
         }
+        parse(yamlString)
         return {
             isValid: true,
         }