Skip to content

Commit d7b1ae6

Browse files
committed
feat: add support for install app version id for helm security
1 parent d758922 commit d7b1ae6

File tree

5 files changed

+12
-4
lines changed

5 files changed

+12
-4
lines changed

src/Shared/Components/Security/SecurityModal/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
export { default as SecurityModal } from './SecurityModal'
66
export { getSecurityScan } from './service'
77
export { getSecurityScanSeveritiesCount } from './utils'
8-
export type { AppDetailsPayload, ExecutionDetailsPayload } from './types'
8+
export type { AppDetailsPayload, ExecutionDetailsPayload, ApiResponseResultType } from './types'

src/Shared/Components/Security/SecurityModal/service.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,14 @@ export const getSecurityScan = async ({
7979
envId,
8080
installedAppId,
8181
artifactId,
82+
installedAppVersionHistoryId,
8283
}: SecurityModalPropsType['appDetailsPayload']) => {
83-
const url = getUrlWithSearchParams(ROUTES.SCAN_RESULT, { appId, envId, installedAppId, artifactId })
84+
const url = getUrlWithSearchParams(ROUTES.SCAN_RESULT, {
85+
appId,
86+
envId,
87+
installedAppId,
88+
artifactId,
89+
installedAppVersionHistoryId,
90+
})
8491
return get(url) as Promise<ResponseType<ApiResponseResultType>>
8592
}

src/Shared/Components/Security/SecurityModal/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ export interface AppDetailsPayload {
3030
envId?: number | string
3131
installedAppId?: number | string
3232
artifactId?: number | string
33+
installedAppVersionHistoryId?: number | string
3334
}
3435

3536
export interface ExecutionDetailsPayload extends Partial<Pick<AppDetailsPayload, 'appId' | 'envId'>> {

src/Shared/Components/Security/SecuritySummaryCard/SecuritySummaryCard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const SecuritySummaryCard = ({
1313
executionDetailsPayload,
1414
}: SecuritySummaryCardProps) => {
1515
const [showSecurityModal, setShowSecurityModal] = useState<boolean>(false)
16-
const { critical, high, medium, low, unknown } = severityCount
16+
const { critical = 0, high = 0, medium = 0, low = 0, unknown = 0 } = severityCount
1717
const totalCount = critical + high + medium + low + unknown
1818
const entities = [
1919
{ label: SEVERITIES.CRITICAL.label, color: SEVERITIES.CRITICAL.color, value: critical },

src/Shared/Components/Security/Vulnerabilities/Vulnerabilities.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ const Vulnerabilities = ({
120120
severityCount={vulnerabilitiesResponse.result.severityCount}
121121
scanToolId={vulnerabilitiesResponse.result.scanToolId}
122122
{...(isScanV2Enabled
123-
? { appDetailsPayload: { appId: 7, envId: 2, artifactId: 235 } }
123+
? { appDetailsPayload: { appId: applicationId, envId: environmentId, artifactId } }
124124
: { executionDetailsPayload: { appId: applicationId, envId: environmentId, artifactId } })}
125125
/>
126126
</div>

0 commit comments

Comments
 (0)