refactor: Update async handling in AppStatusModal and service to improve error management and simplify parameters

Author: AbhishekA1509

src/Shared/Components/AppStatusModal/AppStatusModal.component.tsx

@@ -62,7 +62,7 @@ const AppStatusModal = ({
         fetchedAppDetailsError,
         reloadInitialAppDetails,
         setFetchedAppDetails,
-    ] = useAsync(getAppDetailsWrapper, [appId, envId], type === 'release')
+    ] = useAsync(getAppDetailsWrapper, [], type === 'release')
 
     const appDetails = type === 'release' ? fetchedAppDetails : appDetailsProp
 
@@ -82,7 +82,8 @@ const AppStatusModal = ({
                     envId: appDetails.environmentId,
                     showTimeline:
                         selectedTab === AppStatusModalTabType.DEPLOYMENT_STATUS &&
-                        appDetails.deploymentAppType !== DeploymentAppTypes.HELM,
+                        appDetails.deploymentAppType !== DeploymentAppTypes.HELM &&
+                        !appDetails.isVirtualEnvironment,
                     virtualEnvironmentConfig: appDetails.isVirtualEnvironment
                         ? {
                               processVirtualEnvironmentDeploymentData,
@@ -105,12 +106,9 @@ const AppStatusModal = ({
         deploymentStatusDetailsBreakdownDataError,
         reloadDeploymentStatusDetailsBreakdownData,
         setDeploymentStatusDetailsBreakdownData,
-    ] = useAsync(
-        getDeploymentStatusWrapper,
-        [appId, envId, showDeploymentStatusModal, selectedTab],
-        !!showDeploymentStatusModal,
-        { resetOnChange: false },
-    )
+    ] = useAsync(getDeploymentStatusWrapper, [showDeploymentStatusModal, selectedTab], !!showDeploymentStatusModal, {
+        resetOnChange: false,
+    })
 
     const handleAppDetailsExternalSync = async () => {
         appDetailsPollingTimeoutRef.current = setTimeout(
@@ -133,7 +131,12 @@ const AppStatusModal = ({
             deploymentStatusDetailsBreakdownData?.deploymentStatus,
         )
 
-        const pollingIntervalFromFlag = Number(window._env_.DEVTRON_APP_DETAILS_POLLING_INTERVAL) || 30000
+        const pollingIntervalFromFlag =
+            Number(
+                appDetails.appType !== AppType.DEVTRON_HELM_CHART
+                    ? window._env_.DEVTRON_APP_DETAILS_POLLING_INTERVAL
+                    : window._env_.HELM_APP_DETAILS_POLLING_INTERVAL,
+            ) || 30000
 
         deploymentStatusPollingTimeoutRef.current = setTimeout(
             async () => {

src/Shared/Components/AppStatusModal/service.ts

@@ -21,7 +21,7 @@ export const getAppDetails = async ({
         'env-id': envId,
     })
 
-    const [appDetails, resourceTree] = await Promise.all([
+    const [appDetailsResponse, resourceTreeResponse] = await Promise.allSettled([
         get<Omit<AppDetails, 'resourceTree'>>(`${ROUTES.APP_DETAIL}/v2${queryParams}`, {
             abortControllerRef,
         }),
@@ -30,6 +30,13 @@ export const getAppDetails = async ({
         }),
     ])
 
+    if (appDetailsResponse.status === 'rejected') {
+        throw appDetailsResponse.reason
+    }
+
+    const appDetails = appDetailsResponse.value
+    const resourceTree = resourceTreeResponse.status === 'fulfilled' ? resourceTreeResponse.value : null
+
     return {
         ...(appDetails.result || ({} as AppDetails)),
         resourceTree: resourceTree.result,