refactor: remove height to deduct from Reload, ErrorScreenManager and ErrorPage

Author: eshankvaish

src/Common/ErrorPage.tsx

@@ -20,7 +20,7 @@ import GenericEmptyState from './EmptyState/GenericEmptyState'
 import { ErrorPageType } from './Types'
 import { noop, refresh, reportIssue } from './Helper'
 
-const ErrorPage = ({ code, image, title, subTitle, imageType, heightToDeduct, redirectURL, reload }: ErrorPageType) => {
+const ErrorPage = ({ code, image, title, subTitle, imageType, redirectURL, reload }: ErrorPageType) => {
     const { push } = useHistory()
     const redirectToHome = () => {
         push(redirectURL || `/${ROUTES.APP_LIST}`)
@@ -75,7 +75,6 @@ const ErrorPage = ({ code, image, title, subTitle, imageType, heightToDeduct, re
             isButtonAvailable={isButtonAvailable}
             renderButton={renderGenerateButton}
             imageType={imageType}
-            heightToDeduct={heightToDeduct}
         />
     )
 }

src/Common/ErrorScreenManager.tsx

@@ -27,7 +27,6 @@ const ErrorScreenManager = ({
     reload,
     subtitle,
     reloadClass,
-    heightToDeduct,
     redirectURL,
     imageType = ImageType.Large,
 }: ErrorScreenManagerProps) => {
@@ -41,7 +40,6 @@ const ErrorScreenManager = ({
                         subTitle={subtitle || ERROR_EMPTY_SCREEN.BAD_REQUEST_MESSAGE}
                         image={badRequest}
                         imageType={imageType}
-                        heightToDeduct={heightToDeduct}
                         reload={reload}
                     />
                 )
@@ -53,7 +51,6 @@ const ErrorScreenManager = ({
                         subTitle={subtitle || ERROR_EMPTY_SCREEN.UNAUTHORIZED_MESSAGE}
                         image={unauthorized}
                         imageType={imageType}
-                        heightToDeduct={heightToDeduct}
                     />
                 )
             case ERROR_STATUS_CODE.PERMISSION_DENIED:
@@ -64,7 +61,6 @@ const ErrorScreenManager = ({
                         subTitle={subtitle || ERROR_EMPTY_SCREEN.FORBIDDEN_MESSAGE}
                         image={unauthorized}
                         imageType={imageType}
-                        heightToDeduct={heightToDeduct}
                     />
                 )
             case ERROR_STATUS_CODE.NOT_FOUND:
@@ -75,7 +71,6 @@ const ErrorScreenManager = ({
                         subTitle={subtitle || ERROR_EMPTY_SCREEN.PAGE_NOT_EXIST}
                         image={notFound}
                         imageType={imageType}
-                        heightToDeduct={heightToDeduct}
                         redirectURL={redirectURL}
                     />
                 )
@@ -87,7 +82,6 @@ const ErrorScreenManager = ({
                         subTitle={subtitle || ERROR_EMPTY_SCREEN.INTERNAL_SERVER_ERROR_MESSAGE}
                         image={badRequest}
                         imageType={imageType}
-                        heightToDeduct={heightToDeduct}
                         reload={reload}
                     />
                 )
@@ -99,7 +93,6 @@ const ErrorScreenManager = ({
                         subTitle={subtitle || ERROR_EMPTY_SCREEN.BAD_GATEWAY_MESSAGE}
                         image={badRequest}
                         imageType={imageType}
-                        heightToDeduct={heightToDeduct}
                         reload={reload}
                     />
                 )
@@ -111,12 +104,11 @@ const ErrorScreenManager = ({
                         subTitle={subtitle || ERROR_EMPTY_SCREEN.SERVICE_TEMPORARY_UNAVAILABLE_MESSAGE}
                         image={badRequest}
                         imageType={imageType}
-                        heightToDeduct={heightToDeduct}
                         reload={reload}
                     />
                 )
             default:
-                return <Reload heightToDeduct={heightToDeduct} reload={reload} className={reloadClass} />
+                return <Reload reload={reload} className={reloadClass} />
         }
     }
     return getMessage()

src/Common/Reload.tsx

@@ -21,11 +21,10 @@ import { refresh } from './Helper'
 /**
  * @deprecated Use APIResponseHandler (Preferred) or error screen manager instead
  */
-export default function Reload({ reload, className = '', heightToDeduct = 0 }: ReloadType) {
+export default function Reload({ reload, className = '' }: ReloadType) {
     return (
         <article
             className={`flex w-100 h-100 ${className}`}
-            {...(heightToDeduct > 0 && { style: { height: `calc(100vh - ${heightToDeduct}px)` } })}
         >
             <div className="flex column w-250 dc__align-center" data-testid="reload">
                 <img src={loadingFailure} style={{ height: 'auto' }} className="w-100 mb-12" alt="load-error" />

src/Common/Types.ts

@@ -180,7 +180,6 @@ export interface ErrorPageType
     extends Pick<GenericEmptyStateType, 'image' | 'title' | 'subTitle' | 'renderButton' | 'imageType'>,
         Pick<ErrorScreenManagerProps, 'reload' | 'redirectURL'> {
     code: number
-    heightToDeduct?: number
     redirectURL?: string
     reload?: () => void
 }
@@ -191,7 +190,6 @@ export interface ErrorScreenManagerProps {
     reload?: (...args) => any
     subtitle?: React.ReactChild
     reloadClass?: string
-    heightToDeduct?: number
     /**
      * Would be used to redirect URL in case of 404
      * @default - APP_LIST
@@ -258,7 +256,6 @@ export type InfoColourBarType = InfoColourBarMessageProp & {
 export interface ReloadType {
     reload?: (event?: any) => void
     className?: string
-    heightToDeduct?: number
 }
 
 export interface RadioGroupItemProps {