Merge pull request #526 from devtron-labs/qa/build-infra-v3

refactor: use structuredClone for deep cloning in BuildInfraForm and utils

Author: AbhishekA1509

src/Pages/GlobalConfigurations/BuildInfra/UseBuildInfraForm.tsx

@@ -118,7 +118,9 @@ const useBuildInfraForm = ({
         const targetPlatform =
             data && 'targetPlatform' in data && Object.hasOwn(data, 'targetPlatform') ? data.targetPlatform : ''
         const currentConfiguration = currentInput.configurations[targetPlatform]
-        const lastSavedConfiguration = profileResponse.profile.configurations[targetPlatform] || currentConfiguration
+        const lastSavedConfiguration = structuredClone(
+            profileResponse.profile.configurations[targetPlatform] || currentConfiguration,
+        )
 
         switch (action) {
             case BuildInfraMetaConfigTypes.DESCRIPTION: {
@@ -236,9 +238,9 @@ const useBuildInfraForm = ({
             case 'de_activate_cm':
             case 'de_activate_cs': {
                 const { id, componentType } = data
+                const currentInfraConfigType = CM_SECRET_COMPONENT_TYPE_TO_INFRA_CONFIG_MAP[componentType]
                 // Would just convert isOverridden to true and replace value with default value
-                const cmSecretValue = currentConfiguration[CM_SECRET_COMPONENT_TYPE_TO_INFRA_CONFIG_MAP[componentType]]
-                    .value as BuildInfraCMCSValueType[]
+                const cmSecretValue = currentConfiguration[currentInfraConfigType].value as BuildInfraCMCSValueType[]
                 const selectedCMCSIndex = cmSecretValue.findIndex((configMapItem) => configMapItem.id === id)
 
                 if (selectedCMCSIndex === -1 || !cmSecretValue[selectedCMCSIndex].canOverride) {
@@ -254,10 +256,22 @@ const useBuildInfraForm = ({
                 }
 
                 const isActivation = action === 'activate_cm' || action === 'activate_cs'
-                cmSecretValue[selectedCMCSIndex].useFormProps = cmSecretValue[selectedCMCSIndex].defaultValue
                 cmSecretValue[selectedCMCSIndex].isOverridden = isActivation
-                cmSecretValue[selectedCMCSIndex].initialResponse =
-                    cmSecretValue[selectedCMCSIndex].defaultValueInitialResponse
+
+                if (isActivation) {
+                    const lastSavedCMSecretArray = (lastSavedConfiguration[currentInfraConfigType]?.value ||
+                        []) as BuildInfraCMCSValueType[]
+                    const lastSavedCMSecret =
+                        lastSavedCMSecretArray.find((configMapItem) => configMapItem.id === id) ||
+                        cmSecretValue[selectedCMCSIndex]
+
+                    cmSecretValue[selectedCMCSIndex].useFormProps = lastSavedCMSecret?.useFormProps
+                    cmSecretValue[selectedCMCSIndex].initialResponse = lastSavedCMSecret?.initialResponse
+                } else {
+                    cmSecretValue[selectedCMCSIndex].useFormProps = cmSecretValue[selectedCMCSIndex].defaultValue
+                    cmSecretValue[selectedCMCSIndex].initialResponse =
+                        cmSecretValue[selectedCMCSIndex].defaultValueInitialResponse
+                }
 
                 // Will remove error if present
                 if (currentInputErrors[CM_SECRET_COMPONENT_TYPE_TO_INFRA_CONFIG_MAP[componentType]]) {

src/Pages/GlobalConfigurations/BuildInfra/utils.tsx

@@ -196,10 +196,10 @@ const parsePlatformServerConfigIntoUIConfig = (
             })
 
             return {
-                useFormProps: cmSecretFormProps,
-                defaultValue: cmSecretFormProps,
-                initialResponse: configMapSecretData,
-                defaultValueInitialResponse: configMapSecretData,
+                useFormProps: structuredClone(cmSecretFormProps),
+                defaultValue: structuredClone(cmSecretFormProps),
+                initialResponse: structuredClone(configMapSecretData),
+                defaultValueInitialResponse: structuredClone(configMapSecretData),
                 id: getUniqueId(),
                 isOverridden: true,
                 canOverride: !isDefaultProfile,
@@ -265,18 +265,21 @@ const getConfigurationMapWithoutDefaultFallback = (
                 {} as BuildInfraConfigurationMapTypeWithoutDefaultFallback,
             ) ?? ({} as BuildInfraConfigurationMapTypeWithoutDefaultFallback)
 
-        acc[platformName] = platformConfigValuesMap
+        acc[platformName] = structuredClone(platformConfigValuesMap)
 
         return acc
     }, {})
 
 const getPlatformConfigurationsWithDefaultValues = ({
-    profileConfigurationsMap,
-    defaultConfigurationsMap,
+    profileConfigurationsMap: profileConfigurationsMapProp,
+    defaultConfigurationsMap: defaultConfigurationsMapProp,
     platformName,
     isDefaultProfile = false,
-}: GetPlatformConfigurationsWithDefaultValuesParamsType): BuildInfraConfigurationMapType =>
-    Object.values(BuildInfraConfigTypes).reduce<BuildInfraConfigurationMapType>((acc, configType) => {
+}: GetPlatformConfigurationsWithDefaultValuesParamsType): BuildInfraConfigurationMapType => {
+    const profileConfigurationsMap = structuredClone(profileConfigurationsMapProp)
+    const defaultConfigurationsMap = structuredClone(defaultConfigurationsMapProp)
+
+    return Object.values(BuildInfraConfigTypes).reduce<BuildInfraConfigurationMapType>((acc, configType) => {
         const defaultConfiguration = defaultConfigurationsMap[configType]
         const profileConfiguration = profileConfigurationsMap[configType]?.active
             ? profileConfigurationsMap[configType]
@@ -313,7 +316,9 @@ const getPlatformConfigurationsWithDefaultValues = ({
 
             const finalValues: BuildInfraCMCSValueType[] =
                 (profileConfiguration?.value as BuildInfraCMCSValueType[])?.map((configMapSecretData) => {
-                    const defaultConfigInfo = defaultConfigurationValueMap[configMapSecretData.useFormProps.name]
+                    const defaultConfigInfo = structuredClone(
+                        defaultConfigurationValueMap[configMapSecretData.useFormProps.name],
+                    )
 
                     return {
                         ...configMapSecretData,
@@ -365,6 +370,7 @@ const getPlatformConfigurationsWithDefaultValues = ({
 
         return acc
     }, {} as BuildInfraConfigurationMapType)
+}
 
 // Would receive a single profile and return transformed response
 export const getTransformedBuildInfraProfileResponse = ({