feat: update Devtron license DTO to allow nullable fields and improve license status logic

Author: AbhishekA1509

src/Shared/Helpers.tsx

@@ -1076,7 +1076,7 @@ const getDevtronLicenseStatus = ({
         return LicenseStatus.EXPIRED
     }
 
-    if (ttl < reminderThreshold) {
+    if (ttl < reminderThreshold * 24 * 60 * 60) {
         return LicenseStatus.REMINDER_THRESHOLD_REACHED
     }
 
@@ -1087,23 +1087,15 @@ export const parseDevtronLicenseDTOIntoLicenseCardData = <isCentralDashboard ext
     licenseDTO: DevtronLicenseDTO<isCentralDashboard>,
     currentUserEmail?: isCentralDashboard extends true ? string : never,
 ): DevtronLicenseCardProps => {
-    const {
-        isTrial,
-        expiry,
-        ttl,
-        reminderThreshold,
-        organisationMetadata,
-        license,
-        licenseSuffix,
-        claimedByUserDetails,
-    } = licenseDTO || {}
+    const { isTrial, expiry, ttl, reminderThreshold, organisationMetadata, license, claimedByUserDetails } =
+        licenseDTO || {}
 
     return {
         enterpriseName: organisationMetadata?.name || '',
         expiryDate: expiry ? moment(expiry).format(DATE_TIME_FORMATS['DD/MM/YYYY']) : '',
         ttl,
         licenseStatus: getDevtronLicenseStatus({ ttl, reminderThreshold }),
         isTrial,
-        ...(currentUserEmail === claimedByUserDetails?.email ? { licenseKey: license } : { licenseSuffix }),
+        ...(currentUserEmail === claimedByUserDetails?.email ? { licenseKey: license } : { licenseSuffix: license }),
     }
 }

src/Shared/types.ts

@@ -1033,25 +1033,26 @@ export interface AppEnvIdType {
 }
 
 export interface DevtronLicenseBaseDTO {
-    fingerprint: string
-    isTrial: boolean
+    fingerprint: string | null
+    isTrial: boolean | null
     /**
      * In timestamp format
      */
-    expiry: string
+    expiry: string | null
     /**
      * Can be negative, depicts time left in seconds for license to expire
      */
-    ttl: number
+    ttl: number | null
     /**
      * Show a reminder after these many DAYS left for license to expire, i.e,
      * Show if `ttl` is less than `reminderThreshold` [converted to seconds]
      */
-    reminderThreshold: number
+    reminderThreshold: number | null
     organisationMetadata: {
-        name: string
-        domain: string
-    }
+        name: string | null
+        domain: string | null
+    } | null
+    license: string | null
 }
 
 export type DevtronLicenseDTO<isCentralDashboard extends boolean = false> = DevtronLicenseBaseDTO &
@@ -1061,12 +1062,8 @@ export type DevtronLicenseDTO<isCentralDashboard extends boolean = false> = Devt
                   firstName: string
                   lastName: string
                   email: string
-              }
-              license: string
-              licenseSuffix?: never
+              } | null
           }
         : {
               claimedByUserDetails?: never
-              license?: never
-              licenseSuffix: string
           })