Merge pull request #607 from devtron-labs/feat/ev-calc-cleanup

refactor: remove heightToDeduct from generic empty state

Author: eshankvaish

src/Common/EmptyState/GenericEmptyState.tsx

@@ -26,7 +26,6 @@ const GenericEmptyState = ({
     isButtonAvailable,
     classname,
     styles,
-    heightToDeduct,
     imageType,
     renderButton,
     imageClassName,
@@ -53,7 +52,6 @@ const GenericEmptyState = ({
             className={`flex ${isRowLayout ? 'dc__gap-32' : 'column dc__gap-20'} empty-state ${classname || ''}`}
             style={styles}
             data-testid="generic-empty-state"
-            {...(heightToDeduct >= 0 && { style: { ...styles, height: `calc(100vh - ${heightToDeduct}px)` } })}
         >
             {!SvgImage ? (
                 !noImage && (

src/Common/Types.ts

@@ -161,10 +161,6 @@ export interface GenericEmptyStateType {
     subTitle?: ReactNode
     isButtonAvailable?: boolean
     styles?: CSSProperties
-    /**
-     * @deprecated To be removed; use flex based layout instead
-     */
-    heightToDeduct?: number
     imageType?: string
     SvgImage?
     renderButton?: () => JSX.Element